Page MenuHomePhabricator
Create Task
Maniphest T126608

Add <mapframe> maximize button
Closed, ResolvedPublic
Actions

Description

When viewing a page with a map, there should be a "make full screen" button that would expand the map fullscreen. There should be a way to escape/toggle back to pageviewing.

The code to actually make the map full screen has already been merged, now all is needed is the actual button.

Details

SubjectRepoBranchLines +/-
Full screen map button for <mapframe>mediawiki/extensions/Kartographermaster+38 -2
Full screen mode on link click and map dblclickmediawiki/extensions/Kartographermaster+144 -15
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedYurikT127844 Improve Maps UI before production (tracking)
 ResolvedYurikT126608 Add <mapframe> maximize button

Event Timeline

Yurik created this task.Feb 11 2016, 3:19 PM
Yurik raised the priority of this task from to Needs Triage.
Yurik updated the task description. (Show Details)
Yurik added projects: Maps (Kartographer), Maps.
Yurik added subscribers: Yurik, Esanders, MaxSem.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 11 2016, 3:19 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Yurik moved this task from Unsorted to General on the Maps (Kartographer) board.Feb 11 2016, 3:19 PM
Yurik moved this task from All map-related tasks to Kartographer on the Maps board.
MaxSem set Security to None.Feb 11 2016, 8:02 PM
MaxSem added a subscriber: • Tnegrin.
• ksmith moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Feb 11 2016, 11:12 PM
• ksmith moved this task from On Sprint Board to Needs triage on the Discovery-ARCHIVED board.
EBernhardson moved this task from Needs triage to Maps on the Discovery-ARCHIVED board.Feb 11 2016, 11:17 PM
Yurik added a parent task: T127844: Improve Maps UI before production (tracking).Feb 23 2016, 5:05 PM
Yurik moved this task from General to UI tasks on the Maps (Kartographer) board.Feb 23 2016, 5:13 PM
Yurik added subscribers: • Deskana, • JGirault.Feb 23 2016, 5:16 PM
Yurik renamed this task from Implement full screen map to Add <mapframe> maximize button.Mar 2 2016, 2:56 AM
Yurik updated the task description. (Show Details)
gerritbot subscribed.Mar 4 2016, 3:15 AM

Change 274850 had a related patch set uploaded (by Yurik):
Full screen mode on link click and map dblclick

https://gerrit.wikimedia.org/r/274850

gerritbot added a project: Patch-For-Review.Mar 4 2016, 3:15 AM
gerritbot added a comment.Mar 4 2016, 2:50 PM

Change 274850 merged by jenkins-bot:
Full screen mode on link click and map dblclick

https://gerrit.wikimedia.org/r/274850

Yurik removed a project: Patch-For-Review.Mar 4 2016, 2:53 PM

Removing Patch-For-Review - double-click full screen works, now need to implement the actual button.

Yurik updated the task description. (Show Details)Mar 4 2016, 2:54 PM
gerritbot added a comment.Mar 5 2016, 1:12 AM

Change 275145 had a related patch set uploaded (by Yurik):
Full screen map button for <mapframe>

https://gerrit.wikimedia.org/r/275145

gerritbot added a project: Patch-For-Review.Mar 5 2016, 1:12 AM
Yurik claimed this task.Mar 5 2016, 1:37 AM
gerritbot added a comment.Mar 5 2016, 2:07 AM

Change 275145 merged by jenkins-bot:
Full screen map button for <mapframe>

https://gerrit.wikimedia.org/r/275145

Esanders closed this task as Resolved.Mar 5 2016, 5:00 PM
stjn mentioned this in T191647: <mapframe> maximise button has strange padding.Apr 6 2018, 5:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL