Page MenuHomePhabricator

Scap should restart job runners to pick up new config
Closed, InvalidPublic

Description

Mostly noticed from the parent task when db config changes, but in theory any config or code change should require a job runner restart.

Note, we have scap --restart already but that doesn't run by default and applies to all nodes, not just job runners.

Related Objects

StatusAssignedTask
Resolvedhashar
Resolvedhashar
ResolvedJoe
ResolvedLegoktm
Declineddemon
ResolvedJoe
ResolvedReedy
ResolvedNone
OpenNone
OpenNone
Resolvedtomasz
Resolvedkaldari
Resolvedkaldari
OpenNone
DeclinedNone
ResolvedNone
ResolvedJoe
ResolvedNone
ResolvedJoe
ResolvedNone
ResolvedJoe
Resolvedkaldari
Resolvedjcrespo
ResolvedVolans
Resolvedaaron
InvalidNone

Event Timeline

demon created this task.Feb 11 2016, 5:47 PM
demon raised the priority of this task from to Normal.
demon updated the task description. (Show Details)
demon added subscribers: demon, aaron, thcipriani and 2 others.
Restricted Application added a project: codfw-rollout. · View Herald TranscriptFeb 11 2016, 5:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Joe set Security to None.
Joe added a subscriber: Joe.Apr 28 2016, 10:12 AM

This is not what happens. As the jobrunner itself lives in https://phabricator.wikimedia.org/diffusion/GJOB/ and doesn't use mediawiki-config at all.

What you observed is most likely some long-running job which is being executed by HHVM, not the jobrunner. Those jobs are still using the old configuration of course; wether it is better to abort jobs abruptly or to have a small lag in the atomicity of changes? That should be decided on a time-to-time basis.

Also, scap's restart feature is seriously broken (I will comment on that in another ticket).

I suggest a rewording of the title of this, for now closing as "invalid"

Joe closed this task as Invalid.Apr 28 2016, 10:12 AM
demon added a comment.Apr 28 2016, 1:44 PM

Yeah this task is bogus, thx for tidying up.