Scrolling page should not stop and zoom when mouse is over a map
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Yurik
	Feb 11 2016, 8:43 PM

Description

When scrolling a page that contains a map, especially with the mouse wheel, the scrolling should not stop and switch to zoom-in/out mode just because the mouse happened to be over a map. Page scrolling should disable map zoom until some time after the scroll is done.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Fix the map stopping the scroll and zooming with the open source script leaflet.sleep.js.	mediawiki/extensions/Kartographer	master	+129 -1
[Alternative] Fix the map capturing the scroll and zooming.	mediawiki/extensions/Kartographer	master	+3 -6
[Alternative] Fix the map stopping the scroll and zooming with the open source script leaflet.sleep.js.	mediawiki/extensions/Kartographer	master	+129 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Yurik	T127844 Improve Maps UI before production (tracking)
		Resolved		• JGirault	T126659 Scrolling page should not stop and zoom when mouse is over a map

Event Timeline

Yurik created this task.Feb 11 2016, 8:43 PM

Yurik assigned this task to • JGirault.

Yurik raised the priority of this task from to Medium.

Yurik updated the task description. (Show Details)

Yurik added projects: Maps (Kartographer), Maps.

Yurik added subscribers: Yurik, MaxSem, EBernhardson.

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 11 2016, 8:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Yurik moved this task from Unsorted to General on the Maps (Kartographer) board.Feb 11 2016, 8:44 PM

Yurik moved this task from All map-related tasks to Kartographer on the Maps board.

EBernhardson moved this task from Needs triage to Maps on the Discovery-ARCHIVED board.Feb 11 2016, 11:17 PM

Yurik added a parent task: T127844: Improve Maps UI before production (tracking).Feb 23 2016, 5:05 PM

Yurik moved this task from General to UI tasks on the Maps (Kartographer) board.Feb 23 2016, 5:12 PM

Yurik added subscribers: • Deskana, • JGirault.Feb 23 2016, 5:16 PM

Yurik merged a task: T129592: Map zooms in/out while scrolling the page in Read mode.Mar 11 2016, 12:37 AM

Yurik added a subscriber: Ryasmeen.

Change 279088 had a related patch set uploaded (by JGirault):
Fix the map stopping the scroll and zooming with the open source script leaflet.sleep.js.

https://gerrit.wikimedia.org/r/279088

gerritbot added a project: Patch-For-Review.Mar 23 2016, 6:58 AM

I had fixed the issue for a personal project with mousewheel listeners on the page, that will manage a scrolling class to body when scrolling. Then I would have a CSS rule such as:

.scrolling .map {
    pointer-events: none;
}

I found browsing stackexchange an existing script leaflet.sleep.js that solves the problem specifically for leaflet.js. It seems to do the job pretty well, and it allows a few options (like having an overlay when the map is asleep) that could be interesting to test.

Change 279285 had a related patch set uploaded (by JGirault):
[Alternative] Fix the map stopping the scroll and zooming with the open source script leaflet.sleep.js.

https://gerrit.wikimedia.org/r/279285

Change 279286 had a related patch set uploaded (by JGirault):
[Alternative] Fix the map capturing the scroll and zooming.

https://gerrit.wikimedia.org/r/279286

Yurik closed this task as Resolved.Mar 25 2016, 12:54 AM

Change 279285 merged by jenkins-bot:
[Alternative] Fix the map stopping the scroll and zooming with the open source script leaflet.sleep.js.

https://gerrit.wikimedia.org/r/279285

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)).Mar 25 2016, 1:00 AM

Change 279286 abandoned by JGirault:
[Alternative] Fix the map capturing the scroll and zooming.

Reason:
Closing in favor of https://gerrit.wikimedia.org/r/#/c/279285/