Used to be like:
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T119713 Update Help:Notifications | |||
Open | None | T114351 Better organisation for the Notification System | |||
Open | None | T100528 Improve organization and control for Flow notifications (tracking + ideas) | |||
Open | None | T113228 Better organization for the Notification panel | |||
Resolved | Esanders | T119374 Styling adjustments for the Notification Panel | |||
Resolved | Mooeypoo | T126686 'Mark as read' dots menu is misaligned |
Event Timeline
Change 272651 had a related patch set uploaded (by Mooeypoo):
Transform the notification action bar to css table layout
Change 272651 merged by jenkins-bot:
Transform the notification action bar to css table layout
It's no longer misaligned, but now it's all the way over to the right. Is that what we want?
CC @Pginer-WMF
More examples for @Pginer-WMF and @jmatazzoni to confirm whether the layout is acceptable or not:
No, the "..." option is just one more option in the sequence of secondary actions. It should have the same spacing around it as the other ones. As illustrated in T119374:
There doesn't seem to be unmerged code to review here so I would sent to QA for @Etonkovidova to check.
Checked in betalabs - the check mark position is ok?
'Mark as read' in Messages
'Mark as read' in Alerts
'Mark as read' for cross-wiki bundle
'Mark as read' in cross-wiki expanded bundle
@Pginer-WMF, this looks about right though I'm not sure it's hitting your spec in all cases. E.g., in some of the examples the horizontal space looks considerably less than the 20px you specify. Are we there yet or do you want to keep adjusting?
It seems the expand/collapse action is not treated the same as other actions. Adding the missing margin to it would help making things more consistent. If this gets more complicated, it's ok to move it to a separate specific ticket for later since it will affect, for now, the cross-wiki bundle.
It seems the expand/collapse action is not treated the same as other actions. Adding the missing margin to it would help making things more consistent.
@Mooeypoo, are you able to adjust the space around expand/collapse as Pau suggests?
Change 277689 had a related patch set uploaded (by Mooeypoo):
Apply buttons styling to 'expand' bundle button
Checked in betalabs - the horizontal space between the dotdotdot menu seems to be consistent - 22px.