Maniphest T126712

Kill moveFileInputToCover
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Feb 12 2016, 4:37 AM

Tags

Referenced Files

None

Subscribers

Description

We should kill mw.UploadWizardUploadInterface.prototype.moveFileInputToCover. It's slow, causing performance issues by being called for each new upload, and it should not be needed. We'll need need to move the functionality of the "Add files" button out of UploadWizardUpload to do it, though.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move "Add files" functionality from UWUploadInterface to UploadWizard	mediawiki/extensions/UploadWizard	master	+121 -271

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T121901 UploadWizard UI performance abysmal when adding many files to upload at once
		Open		None	T96906 Refactor UploadWizard to be maintainable
		Resolved		matthiasmullie	T89855 Move the interface for adding new files to a new UI class and refactor things around it
		Resolved		matmarex	T39997 [performance] Interval not cleared: 2 Intervals per file
		Resolved		matmarex	T126712 Kill moveFileInputToCover

Event Timeline

matmarex created this task.Feb 12 2016, 4:37 AM

matmarex claimed this task.

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added projects: Technical-Debt, UploadWizard.

matmarex subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 12 2016, 4:37 AM

Restricted Application added subscribers: StudiesWorld, Steinsplitter, Aklapper. · View Herald Transcript

matmarex added a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.Feb 12 2016, 4:37 AM

Change 270295 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Move "Add files" functionality from UWUploadInterface to UploadWizard

https://gerrit.wikimedia.org/r/270295

Restricted Application added a subscriber: Matanya. · View Herald TranscriptFeb 12 2016, 2:58 PM

gerritbot added a project: Patch-For-Review.Feb 12 2016, 2:58 PM

matmarex triaged this task as High priority.Feb 12 2016, 4:55 PM

matmarex added a parent task: T96906: Refactor UploadWizard to be maintainable.Feb 12 2016, 5:10 PM

matmarex added a parent task: T89855: Move the interface for adding new files to a new UI class and refactor things around it.

matmarex mentioned this in T89855: Move the interface for adding new files to a new UI class and refactor things around it.

matmarex added a parent task: T39997: [performance] Interval not cleared: 2 Intervals per file.Feb 18 2016, 4:44 PM

Change 270295 merged by jenkins-bot:
Move "Add files" functionality from UWUploadInterface to UploadWizard

https://gerrit.wikimedia.org/r/270295

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 18 2016, 9:00 PM

matmarex closed this task as Resolved.Feb 18 2016, 9:08 PM

matmarex removed a project: Patch-For-Review.

matmarex set Security to None.

matmarex mentioned this in T39997: [performance] Interval not cleared: 2 Intervals per file.