Page MenuHomePhabricator

PluggableAuth should provide a way to avoid sending redirects.
Closed, ResolvedPublic

Description

In developing the SSO plugin for PluggableAuth, I ran into a problem when Microsoft's crawler was hitting the wiki. The crawler presented SSO credentials that were authenticated by the SSO plugin, but then PluggableAuth would send a redirect which and (combined with another bug that resulted in a redirect), this meant that the crawler thought it was in a redirect loop.

I avoided the problem by adding a hook that would allow me to bypass the redirect if a user in the bot group was the user authenticated.

Event Timeline

MarkAHershberger raised the priority of this task from to Needs Triage.
MarkAHershberger updated the task description. (Show Details)
MarkAHershberger subscribed.

Change 270307 had a related patch set uploaded (by MarkAHershberger):
Add hook to avoid sending redirects if needed

https://gerrit.wikimedia.org/r/270307

Change 270307 merged by Umherirrender:
Add hook to avoid sending redirects if needed

https://gerrit.wikimedia.org/r/270307

cicalese claimed this task.