We should remove support for browsers not supporting HTML5 File API from UploadWizard. I'm pretty sure we were only needing it for IE8, and MediaWiki dropped JS support for it a while ago. This will probably be easier to do after https://gerrit.wikimedia.org/r/#/c/270295/ (rEUWI6ac498c91532).
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T96906 Refactor UploadWizard to be maintainable | |||
| Resolved | matmarex | T131248 Remove old code for browsers not supporting HTML5 File API from UploadWizard | |||
| Resolved | matmarex | T131182 Remove $wgApiFrameOptions = 'SAMEORIGIN' override for UploadWizard wikis | |||
| Resolved | matmarex | T130563 Investigate 'missingparam' errors on 'file' step | |||
| Resolved | matmarex | T126763 Remove support for browsers not supporting HTML5 File API from UploadWizard | |||
| Declined | matmarex | T127371 When UW loads, log whether `mw.fileApi.isAvailable()` is true or false via EventLogging | |||
| Resolved | matmarex | T130167 Special:UploadWizard spins forever on Grade C browsers |
Event Timeline
Comment Actions
Looking at https://developer.mozilla.org/en/docs/Web/API/File https://developer.mozilla.org/en/docs/Web/API/FileReader https://developer.mozilla.org/en/docs/Web/API/FormData – we'd be dropping IE 9 and maybe some mobile browsers.
Comment Actions
(UploadWizard already doesn't work on IE 9, I just tested. You can't even choose a file (clicking the button does nothing) and when I fixed that, I got exceptions from somewhere deep inside. I didn't try debugging further than that because due to T49277, debug mode is broken on IE 9, and its debugger doesn't really work with minified scripts.)
Comment Actions
Change 277938 had a related patch set uploaded (by Bartosz Dziewoński):
Remove the ability to configure enableFormData, enableMultiFileSelect, enableMultipleFiles
Comment Actions
Change 277940 had a related patch set uploaded (by Bartosz Dziewoński):
Treat browsers without HTML5 File API support like grade-C browsers
Comment Actions
Change 277938 merged by jenkins-bot:
Remove the ability to configure enableFormData, enableMultiFileSelect, enableMultipleFiles
Comment Actions
Change 279702 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Drop support for Firefox < 7.0
Comment Actions
Change 277940 merged by jenkins-bot:
Treat browsers without HTML5 File API and FormData support like Grade C browsers
Comment Actions
OK, starting with the 1.27.0-wmf.20 release of MediaWiki (to be deployed next week according to MediaWiki 1.27 Roadmap), UploadWizard will explicitly drop support for a variety of older browsers, notably Firefox 3.6, Internet Explorer 9 and Android 4 stock browser. The requirements are listed at https://www.mediawiki.org/wiki/UploadWizard#Compatibility. As we're not doing browser sniffing, but using feature detection (except for Firefox < 7.0, which has an insidious bug preventing chunked uploading), any browsers not listed there that support the required APIs will continue working as before.
If your browser can't run UploadWizard, you'll see a plain upload form and a message advising what is going on. Here's a screenshot with Firefox 3.6 (it might look a bit different on Commons):
I don't expect this to affect many users. Judging by T130563, this affects no more than ~100 upload attempts per day, compared to ~5000-7000 uploads that are completed with UploadWizard daily. Judging by T130563 also, affected systems are mostly mobile devices with limited capabilities and extremely old desktop/laptop setups, both of which are probably better off with the simple form.
(I'm posting a notification at https://commons.wikimedia.org/wiki/Commons:Village_pump too.)