Page MenuHomePhabricator
Create Task
Maniphest T126777

Defer loading of thumbnails in "Upload" step until after the rest of the interface is shown
Closed, ResolvedPublic
Actions

Description

We should only load thumbnails of the files that are visible on-screen in "Upload" step, especially if the user is adding multiple files.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Rework thumbnail creation in Upload stepmediawiki/extensions/UploadWizardmaster+31 -90
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 12 2016, 5:39 PM
matmarex claimed this task.
matmarex raised the priority of this task from to Medium.
matmarex updated the task description. (Show Details)
matmarex added projects: Multimedia, UploadWizard.
matmarex subscribed.
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptFeb 12 2016, 5:39 PM
matmarex added a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.Feb 12 2016, 5:42 PM
matmarex added a comment.Feb 18 2016, 10:13 PM

Hmm… we actually display all the thumbnails in later steps, so we'll need to load every one of them at some point. Let's just defer this to happen after creating the interface.

gerritbot subscribed.Feb 19 2016, 6:17 PM

Change 271809 had a related patch set uploaded (by Bartosz Dziewoński):
Rework thumbnail creation in Upload step

https://gerrit.wikimedia.org/r/271809

gerritbot added a project: Patch-For-Review.Feb 19 2016, 6:17 PM
gerritbot added a comment.Feb 19 2016, 6:42 PM

Change 271809 merged by jenkins-bot:
Rework thumbnail creation in Upload step

https://gerrit.wikimedia.org/r/271809

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 19 2016, 7:00 PM
matmarex renamed this task from Only load thumbnails of files visible on-screen in "Upload" step to Defer loading of thumbnails in "Upload" step until after the rest of the interface is shown.Feb 28 2016, 11:08 PM
matmarex closed this task as Resolved.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits