mw.widgets.DateInputWidget takes comparably long time to construct, investigate why
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Feb 12 2016, 5:56 PM

Description

mw.widgets.DateInputWidget takes comparably long time to construct, investigate why.

Possible culprits:

We use tons of OOjs UI ButtonWidgets in the CalendarWidget, see T126784.
Moment.js functions, look into moment constructor and moment#isSame.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
mw.widgets.CalendarWidget: Lazy-initialize calendar buttons too	mediawiki/core	master	+48 -34
mw.widgets.DateInputWidget, CalendarWidget: Lazy-initialize calendar when first shown	mediawiki/core	master	+14 -0
mw.widgets.DateInputWidget: Don't construct moment() objects when not needed	mediawiki/core	master	+22 -20

Customize query in gerrit

Related Objects

Mentioned In: T121901: UploadWizard UI performance abysmal when adding many files to upload at once
Mentioned Here: T126784: Rampant use of $.extend() for default configs is slow when constructing big interfaces with many widgets

Event Timeline

matmarex created this task.Feb 12 2016, 5:56 PM

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added a project: MediaWiki-General.

matmarex subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 12 2016, 5:56 PM

matmarex claimed this task.Feb 12 2016, 5:57 PM

matmarex triaged this task as Medium priority.

matmarex added a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.

matmarex set Security to None.

Change 271911 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.DateInputWidget: Don't construct moment() objects when not needed

https://gerrit.wikimedia.org/r/271911

Change 271912 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.DateInputWidget, CalendarWidget: Lazy-initialize calendar when first shown

https://gerrit.wikimedia.org/r/271912

Change 271913 had a related patch set uploaded (by Bartosz Dziewoński):
mw.widgets.CalendarWidget: Lazy-initialize calendar buttons too

https://gerrit.wikimedia.org/r/271913

Turns out that the interface of CalendarWidget is just expensive to construct. Not just the ButtonWidgets (about 5 ms per CalendarWidget), but the whole calendar (about 15 ms per CalendarWidget). Interesting.

matmarex lowered the priority of this task from Medium to Low.Feb 19 2016, 10:17 PM

matmarex mentioned this in T121901: UploadWizard UI performance abysmal when adding many files to upload at once.

matmarex removed a parent task: T121901: UploadWizard UI performance abysmal when adding many files to upload at once.Feb 19 2016, 10:19 PM

Change 271911 merged by jenkins-bot:
mw.widgets.DateInputWidget: Don't construct moment() objects when not needed

https://gerrit.wikimedia.org/r/271911

Change 271912 merged by jenkins-bot:
mw.widgets.DateInputWidget, CalendarWidget: Lazy-initialize calendar when first shown

https://gerrit.wikimedia.org/r/271912

Change 271913 merged by jenkins-bot:
mw.widgets.CalendarWidget: Lazy-initialize calendar buttons too

https://gerrit.wikimedia.org/r/271913

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 20 2016, 12:00 AM

Now good enough?

matmarex closed this task as Resolved.Feb 28 2016, 10:54 PM

matmarex removed a project: Patch-For-Review.

mw.widgets.DateInputWidget takes comparably long time to construct, investigate whyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

mw.widgets.DateInputWidget takes comparably long time to construct, investigate why
Closed, ResolvedPublic
Actions