Page MenuHomePhabricator

[Task] Remove references to Entity in tests in the Wikibase component
Closed, ResolvedPublic

Description

There are still lots of references to Entity in our tests in the Wikibase component. Most of them should be easily removable since we know which entity types we use in our tests.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
DuplicateNone
InvalidLydia_Pintscher
OpenNone
OpenNone
StalledNone
OpenNone
ResolvedAddshore
Resolvedthiemowmde
ResolvedAddshore
ResolvedBene
Resolveddaniel

Event Timeline

Bene claimed this task.
Bene raised the priority of this task from to Medium.
Bene updated the task description. (Show Details)
Bene removed Bene as the assignee of this task.Feb 12 2016, 5:57 PM
Bene set Security to None.
daniel renamed this task from [Task] Remove references to Entity in tests to [Task] Remove references to Entity in tests in the Wikibase component.Mar 3 2016, 2:13 PM
daniel updated the task description. (Show Details)

Change 274705 had a related patch set uploaded (by Daniel Kinzler):
Typehint against EntityDocument instead of Entity in unit tests.

https://gerrit.wikimedia.org/r/274705

Change 274705 merged by jenkins-bot:
Typehint against EntityDocument instead of Entity in unit tests.

https://gerrit.wikimedia.org/r/274705

In all of Wikibase php code I found these references that might still need to be changed:

lib/tests/phpunit/changes/EntityChangeTest.php: return 'Wikibase\DataModel\Entity\Entity';
repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php: ->with( $this->isInstanceOf( 'Wikibase\DataModel\Entity\Entity' ) )

repo/includes/Hooks/EditFilterHookRunner.php: throw new InvalidArgumentException( '$new must be instance of Entity or EntityRedirect' );

Change 274918 had a related patch set uploaded (by Daniel Kinzler):
Change references to Entity to EntityDocument

https://gerrit.wikimedia.org/r/274918

Change 274918 merged by jenkins-bot:
Fix reference to Entity class in exception message.

https://gerrit.wikimedia.org/r/274918