Page MenuHomePhabricator
Create Task
Maniphest T126789

[Task] Remove references to Entity in tests in the Wikibase component
Closed, ResolvedPublic
Actions

Description

There are still lots of references to Entity in our tests in the Wikibase component. Most of them should be easily removable since we know which entity types we use in our tests.

Details

SubjectRepoBranchLines +/-
Fix reference to Entity class in exception message.mediawiki/extensions/Wikibasemaster+1 -1
Typehint against EntityDocument instead of Entity in unit tests.mediawiki/extensions/Wikibasemaster+167 -145
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedBeneT126769 [Tracking] Don't typehint against Entity
 ResolveddanielT126789 [Task] Remove references to Entity in tests in the Wikibase component

Event Timeline

Bene created this task.Feb 12 2016, 5:57 PM
Bene claimed this task.
Bene raised the priority of this task from to Medium.
Bene updated the task description. (Show Details)
Bene added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2016, 5:57 PM
Bene removed Bene as the assignee of this task.Feb 12 2016, 5:57 PM
Bene set Security to None.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Feb 18 2016, 12:48 PM
daniel renamed this task from [Task] Remove references to Entity in tests to [Task] Remove references to Entity in tests in the Wikibase component.Mar 3 2016, 2:13 PM
daniel updated the task description. (Show Details)
gerritbot subscribed.Mar 3 2016, 2:14 PM

Change 274705 had a related patch set uploaded (by Daniel Kinzler):
Typehint against EntityDocument instead of Entity in unit tests.

https://gerrit.wikimedia.org/r/274705

gerritbot added a project: Patch-For-Review.Mar 3 2016, 2:14 PM
daniel added a project: Wikidata-Sprint-2016-03-01.Mar 3 2016, 2:19 PM
daniel subscribed.

picking this up, since it blocks T126769: [Tracking] Don't typehint against Entity.

daniel claimed this task.Mar 3 2016, 2:20 PM
daniel moved this task from Proposed to Review on the Wikidata-Sprint-2016-03-01 board.
gerritbot added a comment.Mar 3 2016, 3:24 PM

Change 274705 merged by jenkins-bot:
Typehint against EntityDocument instead of Entity in unit tests.

https://gerrit.wikimedia.org/r/274705

JanZerebecki subscribed.Mar 3 2016, 5:43 PM

In all of Wikibase php code I found these references that might still need to be changed:

lib/tests/phpunit/changes/EntityChangeTest.php: return 'Wikibase\DataModel\Entity\Entity';
repo/tests/phpunit/includes/Hooks/EditFilterHookRunnerTest.php: ->with( $this->isInstanceOf( 'Wikibase\DataModel\Entity\Entity' ) )

repo/includes/Hooks/EditFilterHookRunner.php: throw new InvalidArgumentException( '$new must be instance of Entity or EntityRedirect' );

JanZerebecki moved this task from Review to Backlog on the Wikidata-Sprint-2016-03-01 board.Mar 3 2016, 5:43 PM
gerritbot added a comment.Mar 4 2016, 10:19 AM

Change 274918 had a related patch set uploaded (by Daniel Kinzler):
Change references to Entity to EntityDocument

https://gerrit.wikimedia.org/r/274918

gerritbot added a comment.Mar 4 2016, 11:00 AM

Change 274918 merged by jenkins-bot:
Fix reference to Entity class in exception message.

https://gerrit.wikimedia.org/r/274918

thiemowmde closed this task as Resolved.Mar 4 2016, 11:45 AM
thiemowmde subscribed.

@JanZerebecki, the issues you mentioned are fixed in https://gerrit.wikimedia.org/r/274918 and https://gerrit.wikimedia.org/r/274766.

thiemowmde moved this task from Backlog to Done on the Wikidata-Sprint-2016-03-01 board.Mar 4 2016, 11:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits