Page MenuHomePhabricator
Create Task
Maniphest T126791

Certain images do not load when wgLazyLoadedImages is true
Closed, ResolvedPublic
Actions

Description

Visit http://reading-web-staging.wmflabs.org/wiki/Syrian_Civil_War?mobileaction=beta
In stable there are various flags under the "Main belligerents" section but on beta these never load and we see an infinite spinner.

Screen Shot 2016-02-12 at 10.03.26 AM.png (344×544 px, 64 KB)

Details

SubjectRepoBranchLines +/-
Lazy load all images that have been replaced by the placeholdermediawiki/extensions/MobileFrontendmaster+10 -11
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 Resolveddr0ptp4ktT114542 Next Generation Content Loading and Routing, in Practice
 Duplicate• JhernandezT104432 [EPIC]: Improve mobile site performance
 Duplicatedr0ptp4ktT120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT113066 [GOAL] Make Wikipedia more accessible to 2G connections
 ResolvedJdlrobsonT124390 [GOAL] Load images with care
 DeclinedBBlackT127883 Enable lazy loaded images for 50% of users in production
 ResolvedJdlrobsonT126590 Deploy lazy images to Mobile web beta
 ResolvedphuedxT126592 Remove magic number timeout if possible when lazy loading images
 ResolvedJdlrobsonT126593 Possible problems of loading noscript contents as text when lazy loading images
 ResolvedJdlrobsonT126791 Certain images do not load when wgLazyLoadedImages is true
 Resolved• JhernandezT126591 Refreshing page with lazy loading images enabled causes images to not load *on load*.
 Resolved• JhernandezT127128 Images above the fold should not be lazily loaded
 DeclinedBBlackT135762 A/B Testing solid framework
Resolved• NuriaT143694 Preliminary Design document for A/B testing

Event Timeline

Jdlrobson created this task.Feb 12 2016, 6:04 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MobileFrontend.
Jdlrobson removed a parent task: T124390: [GOAL] Load images with care.
Jdlrobson added a parent task: T126590: Deploy lazy images to Mobile web beta.
Jdlrobson added subscribers: Krinkle, Peter, • Nirzar and 7 others.
Jdlrobson mentioned this in T124770: Feature flagged Lazily load images.Feb 12 2016, 6:12 PM
Jdlrobson triaged this task as Medium priority.Feb 17 2016, 6:13 PM
Jdlrobson moved this task from Backlog to Parking lot on the MobileFrontend board.Feb 18 2016, 6:25 PM
Krinkle added a parent task: T124390: [GOAL] Load images with care.Feb 23 2016, 4:35 PM
Jdlrobson added a project: Reading-Web-Sprint-67-If, Then, Else...?.Feb 23 2016, 10:04 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-67-If, Then, Else...? board.Feb 29 2016, 5:20 PM
Jdlrobson claimed this task.Mar 1 2016, 11:04 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-67-If, Then, Else...? board.
Jdlrobson added a comment.Mar 1 2016, 11:57 PM

Seems to assume that all images are wrapped in an anchor element with class image. Not true...

gerritbot subscribed.Mar 1 2016, 11:59 PM

Change 274317 had a related patch set uploaded (by Jdlrobson):
Lazy load all images that have been replaced by the placeholder

https://gerrit.wikimedia.org/r/274317

gerritbot added a project: Patch-For-Review.Mar 1 2016, 11:59 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 2 2016, 12:01 AM
• Jhernandez moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 4 2016, 12:35 PM
• Jhernandez subscribed.

+2d!

gerritbot added a comment.Mar 4 2016, 6:22 PM

Change 274317 merged by jenkins-bot:
Lazy load all images that have been replaced by the placeholder

https://gerrit.wikimedia.org/r/274317

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 4 2016, 7:00 PM
Jdlrobson closed this task as Resolved.Mar 4 2016, 10:22 PM

Verified on reading web staging

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-67-If, Then, Else...? board.Mar 4 2016, 10:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL