Page MenuHomePhabricator

[Bug] Going from a zero-rated site ("Wikipedia language") to a non-zero-rated site does not trigger Wikipedia Zero state change event
Closed, DeclinedPublic

Description

Description

A small number of Zero providers restrict the wiki languages for which data is zero-rated. Going from a zero-rated language to a non-zero-rated language should trigger a state change event that warns the user traffic is no longer zero-rated, but currently no such event is triggered.

Interestingly, a state change event does occur when going in the other direction, from a non-zero-rated language to a zero-rated language.

See also semi-related bug T126997: [Bug] Switching the Wikipedia language while Zero is enabled does not update the nav menu zero message.

Steps to reproduce

  1. Enable zero-rating on a provider with only some languages whitelisted
  2. Obtain Wikipedia Zero state in the app
  3. Change the Wikipedia Language to a non-zero-rated language and continue browsing

Expected results

A state change event is triggered, notifying the user that Wikipedia Zero is no longer active.

Actual results

No such state change event is triggered, and the Wikipedia Zero chrome remains in place.

Environments observed

App version: dev
Android OS versions: M
Device model: 6P
Device language: English

Event Timeline

Mholloway raised the priority of this task from to Needs Triage.
Mholloway updated the task description. (Show Details)
Mholloway subscribed.
Mholloway renamed this task from Going from a zero-rated site ("Wikipedia language") to a non-zero-rated site does not trigger Wikipedia Zero state change event to [Bug] Going from a zero-rated site ("Wikipedia language") to a non-zero-rated site does not trigger Wikipedia Zero state change event.Feb 12 2016, 10:23 PM

Change 270445 had a related patch set uploaded (by Mholloway):
Post WikipediaZeroStateChangeEvent on app language change

https://gerrit.wikimedia.org/r/270445

Change 270445 abandoned by Mholloway:
Post WikipediaZeroStateChangeEvent on app language change

Reason:
This will will take deeper changes than I expected and should wait until the Zero stuff is refactored/consolidated.

https://gerrit.wikimedia.org/r/270445

@Mholloway, @Dbrant, should this move to bug backlog? This seems user facing?

Mholloway closed this task as Declined.EditedNov 9 2016, 9:52 PM

We no longer use WikipediaZeroStateChangeEvents to trigger zero config checking, but rather take the simpler approach of just inspecting each page/preview response for a header indicating a zero-rated connection.

A Zero state change triggered by a language change should be caught in this way in the normal course of browsing. (On a side note, I'm not sure any active carriers restrict zero-rating by language, so this might be moot in any case.)