Page MenuHomePhabricator

Table end tag following nl emitting template in attribute position
Open, MediumPublic

Event Timeline

Esanders raised the priority of this task from to High.
Esanders updated the task description. (Show Details)
Esanders added a project: Parsoid.
Esanders subscribed.
Jdforrester-WMF renamed this task from Multi-transclusion template breaks whole page rendering to Multi-transclusion template ending in `|}` breaks whole page rendering (presumably end of table is ignored as not in single line context?).Feb 13 2016, 2:05 AM
Jdforrester-WMF subscribed.

Speculating wildly in the title.

Change 397721 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Handle table end following templates in attribute position

https://gerrit.wikimedia.org/r/397721

Arlolra lowered the priority of this task from High to Medium.Dec 13 2017, 10:51 PM

Similarly, here's some cases with indent-pre following a template,

[ 'enwiktionary/قرش',
  'itwiki/Renzo Ravenna',
  'itwiki/Uéslei',
  'itwiki/Russell_Westbrook',
  'itwiki/Bartolomé_Macías',
  'itwiki/Carlos_Griguol',
  'itwiki/Sheldry_Sáez',
  'kaawiki/Orta_a\'sir_sxolastikası',
  'kaawiki/Texnologiya',
  'uzwiki/FIFA Jahon chempionati 2018 saralash bosqichi (AFC)',
  'itwiki/Benedetto Petrone',
  'itwiki/Catê',
  'itwiki/Nordahl_Grieg',
  'itwiki/Ottomix',
  'itwiki/Stefano_Maderno',
  'itwiki/Tōru_Ōkawa',
  'itwiki/Ramón Revilla Jr.',
  'itwiki/Renato Dell\'Andro',
  'itwiki/Maria_de_Cervellòn',
  'itwiki/Pascual_Echagüe',
  'itwiki/Taylor_Hayes_(attrice_pornografica)',
  'itwiki/Lawrence_Krauss',
  'itwiki/Felix_Kroos',
  'itwiki/Stephanie_McMahon',
  'itwiki/Federico Augusto I (re di Sassonia)' ]

See the rendering differences in https://it.wikipedia.org/wiki/Cat%C3%AA vs https://it.wikipedia.org/api/rest_v1/page/html/Cat%C3%AA for example.

Arlolra renamed this task from Multi-transclusion template ending in `|}` breaks whole page rendering (presumably end of table is ignored as not in single line context?) to Table end tag following nl emitting template in attribute position.Jan 22 2019, 7:52 PM

Change 397721 abandoned by Arlolra:
Handle table end tag following nl emitting template in attribute position

Reason:
For now ...

https://gerrit.wikimedia.org/r/397721

Arlolra subscribed.

This is a known difference because Parsoid tokenizes table tags before templates are expanded. Unless this is a common use case, we should probably lint this away and require table closing tags to be on their own line. But if this is a common use case, we'll probably need to deal with it in the TokenStreamPatcher which exists (as a hack) for scenarios like this to patch up the tokenized stream once templates are expanded by reparsing some string tokens.