Maniphest T126976

Codesniffer allows missing space before opening brace
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Feb 15 2016, 2:03 PM

Tags

Referenced Files

None

Subscribers

Description

Following code does not cause any errors or warnings:

if ( !$group ){

Per examples of https://www.mediawiki.org/wiki/Manual:Coding_conventions#General_style it should not be allowed.

Tested with 0.5.1.

Related Objects

Mentioned Here: T89682: Improving static analysis tools for MediaWiki

Event Timeline

Nikerabbit created this task.Feb 15 2016, 2:03 PM

Nikerabbit raised the priority of this task from to Needs Triage.

Nikerabbit updated the task description. (Show Details)

Nikerabbit added a project: MediaWiki-Codesniffer.

Nikerabbit moved this task to Untriaged on the MediaWiki-Codesniffer board.

Nikerabbit subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 15 2016, 2:03 PM

@Legoktm, @Addshore maybe this can be a microtask for T89682: Improving static analysis tools for MediaWiki?

Hi there,I have submitted my changes to Gerrit about this, I hope it may useful :)

polybuildr merged a task: T129313: Add sniff to keep single space between closing parenthesis and opening brace of some statement.Mar 9 2016, 5:12 AM

This is caught by the MediaWiki.WhiteSpace.SpaceBeforeControlStructureBrace.SpaceBeforeControl sniff now.