Page MenuHomePhabricator

Fix nested scrollbars in graph sandbox' s edit box
Closed, ResolvedPublic

Description

When writing a graph in the graph sandbox, if the edit box has enough text, two sets of scroll bars appear, making it very difficult to scroll. This is especially visible if you have a smaller screen or if you zoom in.

Event Timeline

Yurik created this task.Feb 15 2016, 6:40 PM
Yurik raised the priority of this task from to Normal.
Yurik updated the task description. (Show Details)
Yurik added subscribers: Yurik, Danny_B, D3r1ck01, He7d3r.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2016, 6:40 PM
Danny_B set Security to None.
D3r1ck01 added a comment.EditedFeb 15 2016, 8:17 PM

@Yurik, what will you suggest us to do concerning this problem, because i don't think limiting the amount of data needed to write a graph will be a good idea, this can cause a lot of inconveniences to the users. Also, making the edit box to large will not be a good UI practice, so What do you have in mind?

Yurik added a comment.Feb 15 2016, 8:19 PM

@D3r1ck01 of course not :) I simply would like there to be just one set of scrollbars, not two nested ones :) In other words, the scrollbar should be only on the edit window, and when the dividers are moved on the page, the edit control should be properly resized.

Ok @Yurik, Let me see if i can work out something concerning. Will submit a patch if i got the solution :)

@Yurik, row attribute of the text area will definitely solve this problem, I am working on it now and will submit a patch shortly :)

D3r1ck01 claimed this task.Feb 15 2016, 8:32 PM

Change 270822 had a related patch set uploaded (by D3r1ck01):
Fix nested scrollbars in graph sandbox' s edit box

https://gerrit.wikimedia.org/r/270822

Yurik added a comment.Feb 15 2016, 9:45 PM

@D3r1ck01, with PS2, i see these images. On the 3rd, I moved the horizontal divider up, and as you can see, both pair of scrallbars have shown up. Also, on the first 2 images, you can see that there is a blank area underneath the edit box, but before the horizontal divider, which should all be occupied by the edit box.

@Yurik, i see why i was not getting the point right, i have two different edit boxes. On my localhost, i have this:

and online, there is a different view of the Sandbox like this:

What could be wrong?

@D3r1ck01, try to force refresh. I suspect it takes a bit longer to load the code. A few times I saw that first picture myself, but later it loads it ok. No idea what might be causing it though.

@Yurik, i have tried force refresh but nothing is happening. I will release task and place on grasp and if anybody doesn't fix it, and the edit box loads correctly, i will submit a patch. :)

D3r1ck01 removed D3r1ck01 as the assignee of this task.Feb 15 2016, 10:31 PM

Change 270822 abandoned by D3r1ck01:
Fix nested scrollbars in graph sandbox' s edit box

Reason:
Facing problems loading the graph edit box, will get back to this bug later. Someone else can start working on it.

https://gerrit.wikimedia.org/r/270822

The reason @D3r1ck01 saw different view from production is probably the same as in T124633 - the resourceloader datamodule in graph extension does not work correctly when in Debug mode.

Change 280905 had a related patch set uploaded (by Yurik):
Fix the scrollbar issue on the GraphSandbox a couple more UI improvements (adjust the sandbox to the viewport, and some styling)

https://gerrit.wikimedia.org/r/280905

Change 280905 merged by jenkins-bot:
Fix the scrollbar issue on the GraphSandbox a couple more UI improvements (adjust the sandbox to the viewport, and some styling)

https://gerrit.wikimedia.org/r/280905

Yurik closed this task as Resolved.Apr 1 2016, 4:14 PM
Yurik claimed this task.
Yurik added a subscriber: JGirault.

Thanks @JGirault !!