Page MenuHomePhabricator

MMV buttons on file description page are misaligned
Closed, ResolvedPublic

Description

MMV buttons on file description page are misaligned.

Details

Related Gerrit Patches:
mediawiki/extensions/MultimediaViewer : masterFix height of buttons on file description page

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: MediaViewer.
matmarex added a subscriber: matmarex.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 16 2016, 11:56 AM
matmarex added a subscriber: Tgr.

The MediaViewer buttons do not use OOUI; they are constructed manually (processFilePageThumb() in resources/mmv/mmv.bootstrap.js). And they used to be properly aligned, so this seems like a regression in the .mw-ui-button-group CSS class.

It's indeed a regression from be4fe9a52afd6a4fbaeb987813ac02b63b227c5f (T116427). Removing the line added in that commit fixes this. I'm not sure why that broke it.

Change 270936 had a related patch set uploaded (by Bartosz Dziewoński):
Fix height of buttons on file description page

https://gerrit.wikimedia.org/r/270936

Change 270936 merged by jenkins-bot:
Fix height of buttons on file description page

https://gerrit.wikimedia.org/r/270936

matmarex closed this task as Resolved.Feb 16 2016, 8:40 PM
matmarex claimed this task.