Page MenuHomePhabricator
Create Task
Maniphest T127052

MMV buttons on file description page are misaligned
Closed, ResolvedPublic
Actions

Description

MMV buttons on file description page are misaligned.

Unbenannt.PNG (71×378 px, 3 KB)

Details

SubjectRepoBranchLines +/-
Fix height of buttons on file description pagemediawiki/extensions/MultimediaViewermaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 16 2016, 11:56 AM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: MediaViewer.
matmarex subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 16 2016, 11:56 AM
matmarex mentioned this in T113495: Buttons in ButtonGroupWidget don't have same height/are misaligned.Feb 16 2016, 11:56 AM
matmarex added a subscriber: Tgr.
In T113495#1834532, @Tgr wrote:

The MediaViewer buttons do not use OOUI; they are constructed manually (processFilePageThumb() in resources/mmv/mmv.bootstrap.js). And they used to be properly aligned, so this seems like a regression in the .mw-ui-button-group CSS class.

matmarex added a subscriber: Florian.Feb 16 2016, 11:58 AM

It's indeed a regression from be4fe9a52afd6a4fbaeb987813ac02b63b227c5f (T116427). Removing the line added in that commit fixes this. I'm not sure why that broke it.

gerritbot subscribed.Feb 16 2016, 12:04 PM

Change 270936 had a related patch set uploaded (by Bartosz Dziewoński):
Fix height of buttons on file description page

https://gerrit.wikimedia.org/r/270936

gerritbot added a project: Patch-For-Review.Feb 16 2016, 12:04 PM
gerritbot added a comment.Feb 16 2016, 6:24 PM

Change 270936 merged by jenkins-bot:
Fix height of buttons on file description page

https://gerrit.wikimedia.org/r/270936

matmarex closed this task as Resolved.Feb 16 2016, 8:40 PM
matmarex claimed this task.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 17 2016, 10:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL