While trying to test elasticsearch upgrade to 1.7.5, I tried to run browser tests in local Vagrant. Cirrus browser tests fail in multiple places. This seems to be related to https://gerrit.wikimedia.org/r/#/c/257928/ (upgrade to latest version of mediawiki_selenium).
|Resolved||Deskana||T125603 EPIC: Review current ElasticSearch configuration, and use relevance lab to run tests to optimise the configuration to improve search result relevance|
|Resolved||dcausse||T107006 Add a "reverse" suggestion field to workaround the prefix length limitation (typos suggestion)|
|Duplicate||None||T122698 Upgrade ElasticSearch to version >=2.2|
|Resolved||Gehel||T122697 Upgrade ElasticSearch to 1.7.5|
|Resolved||Gehel||T127074 cirrus browser tests fail on Vagrant (and probably in other places)|
vagrant@mediawiki-vagrant:/vagrant/mediawiki/extensions/CirrusSearch/tests/browser$ bundle exec cucumber --tags ~@expect_failure @bad_syntax @clean @api Feature: Searches with syntax errors @setup_main Scenario: Searching for <text>~<text> treats the tilde like a space except that the whole "word" (including tilde) makes a phrase search # features/bad_syntax_api.feature:4 When I api search for ffnonesenseword~catapult # features/step_definitions/search_steps.rb:30 Then Two Words is the first api search result # features/step_definitions/search_steps.rb:304 undefined method `' for nil:NilClass (NoMethodError) ./features/step_definitions/search_steps.rb:310:in `block (2 levels) in <top (required)>' ./features/step_definitions/search_steps.rb:308:in `map' ./features/step_definitions/search_steps.rb:308:in `/^(.+) is( in)? the ((?:[^ ])+(?: or (?:[^ ])+)*) api search result$/' features/bad_syntax_api.feature:6:in `Then Two Words is the first api search result'
Looks like search is not happening (@api_search is nil). Still wondering why...
After much investigation and help from @dcausse, most tests are passing for me locally. Issues were between chair and keyboard.
As a blocker for T122697: Upgrade ElasticSearch to 1.7.5, this shoudl not be an issue anymore. I'll make sure the same tests are failing before and after the elastic search update.