Page MenuHomePhabricator
Create Task
Maniphest T127160

(diff) on Special:Undelete uses hard-coded parentheses
Closed, DeclinedPublic
Actions

Description

In "Page history" list items, the second parameter passed to "undelete-revision-row2" message.

Just missed Google Code-In. :(

Details

SubjectRepoBranchLines +/-
Remove hardcoded parenthesesmediawiki/coremaster+2 -2
Customize query in gerrit

Event Timeline

liangent created this task.Feb 17 2016, 8:53 AM
liangent raised the priority of this task from to Needs Triage.
liangent updated the task description. (Show Details)
liangent added projects: MediaWiki-Internationalization, good first task.
liangent subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 17 2016, 8:53 AM
Haritha28 subscribed.Feb 21 2016, 6:51 AM
Haritha28 claimed this task.Feb 21 2016, 7:08 AM
Haritha28 moved this task from Backlog to Doing on the good first task board.Feb 21 2016, 8:31 AM
gerritbot subscribed.Feb 21 2016, 2:33 PM

Change 272319 had a related patch set uploaded (by Haritha28):
Remove hardcoded parentheses

https://gerrit.wikimedia.org/r/272319

gerritbot added a project: Patch-For-Review.Feb 21 2016, 2:33 PM
siebrand closed this task as Declined.Feb 21 2016, 5:15 PM
siebrand subscribed.

This isn't a case of hard-coded parenthesis. The parentheses are part of message "$1 ($2) $3 . . $4 $5 $6 $7 $8" with key "undelete-revision-row2" in MediaWiki core, and as such i18n is just fine.

Adding the parentheses are proposed in https://gerrit.wikimedia.org/r/#/c/272319/1/includes/specials/SpecialUndelete.php obscures the message (even) further. The solution here, as often, is to have more complete localization.

Because of the above, I'm closing this ticket as declined.

gerritbot added a comment.Jul 27 2016, 2:54 PM

Change 272319 abandoned by Bartosz Dziewoński:
Remove hardcoded parentheses

Reason:
Per task.

https://gerrit.wikimedia.org/r/272319

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 27 2016, 2:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL