Generic.Functions.CallTimePassByReference.NotAllowed false positive when using php5.4 array syntax []
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Feb 17 2016, 9:21 AM

Description

Will file an upstream bug in a bit.

Basically, this is okay:

		Hooks::run( 'SecondaryDataUpdates', array( $title, $old, $recursive, $parserOutput, &$updates ) );

but this is not:

		Hooks::run( 'SecondaryDataUpdates', [ $title, $old, $recursive, $parserOutput, &$updates ] );

	Subject	Repo	Branch	Lines +/-
	Disable Generic.Functions.CallTimePassByReference.NotAllowed	mediawiki/tools/codesniffer	master	+5 -0

Legoktm raised the priority of this task from to Needs Triage.

Legoktm updated the task description. (Show Details)

Legoktm subscribed.

Change 271216 had a related patch set uploaded (by Legoktm):
Disable Generic.Functions.CallTimePassByReference.NotAllowed

Change 271216 merged by jenkins-bot:
Disable Generic.Functions.CallTimePassByReference.NotAllowed

Can this be closed as resolved please since it looks like it has been done and fixed upstream?

Paladox removed a subscriber: gerritbot.

Closed in upstream; merged in downstream... I'd say so. Thanks! :)

Thanks :).