Page MenuHomePhabricator

Draggable list not working as expected in TemplateData
Closed, ResolvedPublic1 Estimated Story Points

Description

Open the TemplateData editor on https://en.wikipedia.org/w/index.php?title=Template:Infobox_SCOTUS_case/doc&action=edit

Moving items up/left works as expected, but when items are moved down/right they end up an extra place to the right.

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: TemplateData, OOUI.
Esanders added subscribers: Esanders, Mooeypoo, matmarex.

Appears to be related to the if ( this.sideInsertion === 'after' ) case in OO.ui.mixin.DraggableGroupElement.prototype.onItemDrop

Change 271965 had a related patch set uploaded (by Esanders):
Fix splice re-ordering when moving items forward

https://gerrit.wikimedia.org/r/271965

Change 271965 merged by jenkins-bot:
Fix splice re-ordering when moving items forward

https://gerrit.wikimedia.org/r/271965

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF set Security to None.