Page MenuHomePhabricator
Create Task
Maniphest T127268

Dismantle ResourceLoader's "targets" system
Open, LowPublic
Actions

Assigned To
None
Authored By
Jdforrester-WMF
Feb 18 2016, 2:22 AM
Tags
Referenced Files
None
Subscribers
Aklapper
alistair3149
AntiCompositeNumber
brion
Catrope
Ciencia_Al_Poder
Florian
View All 27 Subscribers
Tokens
"Like" token, awarded by Mainframe98."Like" token, awarded by Catrope.

Description

Migration guide: https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_for_extension_developers#Target_system

Endlessly discussed and griped about but apparently there's no task.

Background

This system is carelessly leaving behind a trail of maintenance overhead. With new issues popping up all the time. Here's a quick sample just from MediaWiki core (quick Resources.php search for "target" and "mobile").

Fixups:

Issues:

Plan

Right now, the problem is that many extensions rely on using OutputPage::addModule inside hooks to add code. There is no way for mobile or a skin to override these decisions. However, many JavaScript modules assume a certain skin and would break if loaded in the wrong skin.

Existing violations can be determined by using X-Wikimedia-Debug and scanning the logs for the query "message:"not loadable on target"

Prep work

  • Many modules in MobileFrontend set "targets": "mobile". This is a shortcut to making sure code only loads in mobile. A module should either by desktop+mobile or desktop going forward. Fix all violations that set only mobile. The important thing to fix is "where" and how the code gets loaded. Where code needs to only load on mobile it should make use of MobileContext.
  • Error when a module is loaded without the 'desktop' target.
  • We need a mechanism for extensions to load modules in such a way that a skin can disable them (or use a different module in its place). One way might be to move all module registrations to Skin::getDefaultModules and preventing access to addModules and addModuleStyles. This would allow the skin the final say in what modules get added to the page. Is that something that's plausible?
  • Certain modules like gadgets and mobile.site are kept out of mobile by the targets system
  • We'll mark any deprecated modules that are not mobile friendly as 'deprecated' e.g. jquery.ui - while it will be possible to load these on mobile, we'll make sure these are not on the critical path of non-special page views.

Deprecating 'targets' system

  • Move all modules to the new system for module registration.
  • target mode desktop will be used on special pages going forward. This should remove many of the special page related violations.
  • When the logs are running clean, we'll turn off the targets system - all modules will be 'mobile'+'desktop' by default.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+126 -0Tests: Error for any new module that introduces bad targets
mediawiki/coremaster+17 -7ResourceLoader: Default File modules to mobile and desktop targets
mediawiki/coremaster+1 -1resourceloader: Include mobile in default FileModule targets
mediawiki/coremaster+0 -14ResourceLoader: Define targets in a single location
mediawiki/coremaster+1 -4Adjust default targets in RL/Module
mediawiki/extensions/ContentTranslationmaster+1 -0Set QUnit test module to target desktop explicitly
mediawiki/extensions/TemplateSandboxmaster+0 -3Don't prevent the VisualEditor plugin from loading on mobile
mediawiki/extensions/VisualEditormaster+1 -0QUnit test module should explicitly target desktop
mediawiki/extensions/VisualEditormaster+16 -4All modules should target both mobile and desktop targets
mediawiki/extensions/VisualEditormaster+11 -2Set targets explicitly on desktop only module
mediawiki/extensions/ContentTranslationmaster+3 -0Set targets explicitly
mediawiki/extensions/Flowmaster+2 -1ext.flow.visualEditor targets desktop explicitly
mediawiki/extensions/Disambiguatormaster+13 -1Add mobile target to ext.disambiguator
mediawiki/extensions/DarkModemaster+0 -6Dark mode code should load on mobile and desktop targets
mediawiki/extensions/Wikibasemaster+4 -2Make es6 modules available on all targets
mediawiki/extensions/ContentTranslationmaster+7 -0Remove desktop only es6 modules
mediawiki/coremaster+4 -0resources: Should be possible to load upload modules on mobile
mediawiki/extensions/FlaggedRevsmaster+8 -0Enable ext.flaggedRevs.advanced and ext.flaggedRevs.review on mobile
mediawiki/coremaster+1 -0mediawiki.special.createaccount: Allow loading on mobile
mediawiki/coremaster+1 -0mediawiki.action.edit: Set desktop/mobile target
mediawiki/coremaster+4 -0"Enable 'site' and 'site.styles' modules on mobile target (take 2)
mediawiki/coremaster+4 -0Enable 'site' and 'site.styles' modules on mobile target
mediawiki/coremaster+1 -1resourceloader: Bump severity of targets violation to WARNING
mediawiki/coremaster+13 -2resourceloader: Document 'target' query param in StartupModule
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 OpenNoneT127268 Dismantle ResourceLoader's "targets" system
 ResolvedKrinkleT140675 Log modules enqueued with invalid module target
 ResolvedpmiazgaT94086 [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)
 DeclinedNoneT143847 Spike [4hrs]: Identify problematic Hogan templates when run as Mustache
 ResolvedJdlrobsonT149909 [EPIC] Proposal: abandon use of template partials in MobileFrontend for components within components e.g. Button, Icon and Anchor classes
ResolvedJdlrobsonT139798 It should be easier to create new overlays
 DeclinedNoneT209647 MFA: Allow our View's to support easy adding of children
 ResolvedNiedzielskiT202746 Enable babel transpiling in MobileFrontend
 DuplicateReedyT205129 Upgrade Hogan.js
 ResolvedNiedzielskiT205128 Bundle Hogan.js
 ResolvedJdlrobsonT219838 Inline Hogan templates in mobile.startup
 ResolvedJdlrobsonT219839 Bump mediawiki core Mustache version from 1.0.0 to 3.0.1
 DuplicateNoneT219845 Swap Hogan for Mustache
 ResolvedpmiazgaT219846 Remove "mediawiki.template.muhogan" from RelatedArticles
 ResolvedovasilevaT220159 Inline templates for mobile editor
 ResolvedovasilevaT220619 Inline remaining templates
 ResolvedovasilevaT220620 Switch Hogan for Mustache
 DuplicateNoneT49858 Enable jquery.tablesorter on mobile
 ResolvedpmiazgaT171180 Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load)
 DuplicateNoneT127147 Gadget definition "targets=mobile" seem to target mobile and desktop users on ur.wp
 ResolvedpmiazgaT208605 Remove usage of templates in QuickSurveys: Muhogan approach in RelatedArticles and QuickSurveys is error prone
 ResolvedKrinkleT171307 "Module not loadable on target" warning doesn't trigger on desktop (OutputPage mTarget defaults to null)
 ResolvedphuedxT213242 Move OutputPage::setTarget() call from BeforePageDisplay to an earlier hook
 ResolvedJdlrobsonT235712 Fix the most common "Module not loadable on target mobile" warnings (Oct 2019)
 ResolvedovasilevaT236097 Dev: Popups modules should set targets to mobile and desktop
 DuplicateBUG REPORTNoneT249902 Page preview in Minerva show a cut off settings cog
 ResolvedJdlrobsonT235796 The ext.3d.styles module should not be added unconditionally to every page and should set target mobile
 ResolvedJdlrobsonT236943 ext.uls.interlanguage and ext.uls.pt should set targets to mobile and desktop but not ship on Minerva (and possibly loaded via JS)
 ResolvedJdlrobsonT236946 The ext.wikimediaBadges module should set the RL targets property
 ResolvedJdlrobsonT237036 ext.uls.interface should set targets and explicitly not target the Minerva skin
 ResolvedJdlrobsonT237050 The `site` and `site.styles` module should be explictly disabled on mobile rather than abuse the targets system
 ResolvedJdlrobsonT138727 Global modules are not loaded on mobile
 ResolvedsanthoshT290704 Warning: "Skipped unresolvable module ext.cx.entrypoints.languagesearcher.init"
 DeclinedNoneT323542 Forbid new modern code from not targeting mobile
 ResolvedBUG REPORTJdlrobsonT324723 Fix the most common "Module not loadable on target mobile" warnings (December 2022)
 OpenNoneT324991 Make Wikibase not rely on the ResourceLoader target system
 OpenNoneT326428 Make more Wikibase ResourceLoader modules available on mobile as well
 ResolvedLucas_Werkmeister_WMDET326405 Make target of desktop-only Wikibase modules explicit
 OpenNoneT328497 Remove unnecessary targets definitions
 ResolvedkostajhT328544 GrowthExperiments: Remove unnecessary target definitions
 ResolvedcscottT329460 Remove unnecessary targets definitions - ReadingLists
 ResolvedcscottT329541 Remove unnecessary targets definitions - Kartographer
 ResolvedcscottT329549 Remove unnecessary targets definitions - Scribunto
 OpenS_MukutiT329643 CommTech - Remove unnecessary targets definitions
 OpenNoneT328498 Remove desktop / mobile only targeted code from MediaWiki skins and extensions
 OpenNoneT329891 Remove mobile-only modules in Wikistories
OpenNoneT332836 Remove desktop / mobile only targeted code from Growth team extensions
 OpenNoneT332837 Remove desktop / mobile only targeted code from language team extensions
 OpenNoneT332839 Remove desktop / mobile only targeted code from ProofreadPage extension
 OpenNoneT332840 Remove desktop / mobile only targeted code from Graph extension
 ResolvedJdlrobsonT332841 Remove desktop / mobile only targeted code from CirrusSearch extension
 ResolvedJdlrobsonT236944 Remove desktop / mobile only targeted code from editing team extensions
 ResolvedBUG REPORTkostajhT328500 ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
 DuplicateNoneT328522 ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it
 ResolvedkostajhT328535 ResourcesTest::testUnsatisfiableDependencies: The module 'ext.pageTriage.views.toolbar' must not have target 'mobile' because its dependency 'ext.pageTriage.externalTagsOptions' does not have it
 OpenBUG REPORTNoneT328610 Default gadgets to run on mobile
 ResolvedLens0021T303681 RL targets for gadget definition pages

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Krinkle removed projects: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Patch-For-Review.Mar 16 2020, 3:03 AM
Jdlrobson mentioned this in T153473: [Spike, 8hrs] How do we organize and manage our ResourceLoader modules?.Mar 30 2020, 7:54 PM
Krinkle mentioned this in T253582: Let ResourceLoader only register skin modules for the current skin.May 25 2020, 5:33 PM
JohanahoJ added a subscriber: JohanahoJ.Jul 13 2020, 3:21 PM
Krinkle mentioned this in T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019).Oct 22 2020, 11:52 PM
Jdforrester-WMF mentioned this in T270603: Module site.styles generates different output depending on mobile cookie, if $wgMFSiteStylesRenderBlocking = true;.Jan 3 2021, 10:29 PM
gerritbot added a comment.Feb 12 2021, 11:45 PM

Change 663910 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.action.edit: Set desktop/mobile target

https://gerrit.wikimedia.org/r/663910

gerritbot added a project: Patch-For-Review.Feb 12 2021, 11:45 PM
gerritbot added a comment.Feb 13 2021, 3:00 AM

Change 663910 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.action.edit: Set desktop/mobile target

https://gerrit.wikimedia.org/r/663910

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 13 2021, 4:00 AM
Krinkle mentioned this in T266364: Determine cause of 20% increase in minify/req since 15 Oct 2020 (alert).Mar 11 2021, 6:41 PM
Krinkle mentioned this in T71681: Support target=mobile for Gadgets 2.0.Apr 18 2021, 8:19 PM
Ltrlg added a subscriber: Ltrlg.Apr 19 2021, 5:14 PM
Krinkle updated the task description. (Show Details)Jun 9 2021, 7:57 PM
phuedx mentioned this in T254977: Server-side survey configuration filtering.Jun 17 2021, 5:25 PM
Jdlrobson moved this task from Move to Backlog to Untriaged on the Readers-Web-Backlog (Tracking) board.Sep 7 2021, 9:06 PM
Krinkle updated the task description. (Show Details)Sep 9 2021, 11:51 PM
AntiCompositeNumber added a subscriber: AntiCompositeNumber.Sep 17 2021, 5:42 PM
AntiCompositeNumber mentioned this in T291274: Misplaced Atom icon in responsive Monobook.Sep 17 2021, 6:02 PM
Jdlrobson moved this task from Untriaged to Untag on the Readers-Web-Backlog (Tracking) board.Sep 21 2021, 8:30 PM
Jdlrobson removed a project: Readers-Web-Backlog (Tracking).Dec 7 2021, 7:47 PM
Lens0021 added a subscriber: Lens0021.Dec 28 2021, 2:27 AM
Krinkle closed subtask T290704: Warning: "Skipped unresolvable module ext.cx.entrypoints.languagesearcher.init" as Resolved.Jan 10 2022, 5:36 PM
SD0001 mentioned this in T303681: RL targets for gadget definition pages .Mar 13 2022, 1:08 PM
Skierpage mentioned this in T308953: Can't download MIDI of generated score on mobile.May 21 2022, 8:37 PM
kostajh added a subscriber: kostajh.May 25 2022, 7:40 AM
gerritbot added a comment.May 25 2022, 7:40 AM

Change 799262 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] mediawiki.special.createaccount: Allow loading on mobile

https://gerrit.wikimedia.org/r/799262

kostajh mentioned this in T309149: Mobile Create Account page does not immediately validate username.May 25 2022, 7:41 AM
gerritbot added a comment.May 25 2022, 7:57 PM

Change 799262 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.special.createaccount: Allow loading on mobile

https://gerrit.wikimedia.org/r/799262

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 25 2022, 8:00 PM
Universal_Omega added a subscriber: Universal_Omega.Jun 10 2022, 8:03 PM
JohanahoJ mentioned this in T65532: Gadget preferences should hide or discourage entries that can't be enabled in the current skin (e.g. vector-only).Jul 14 2022, 8:48 AM
gerritbot added a comment.Jul 28 2022, 5:02 AM

Change 817927 had a related patch set uploaded (by Krinkle; author: Gergő Tisza):

[mediawiki/extensions/FlaggedRevs@master] Enable ext.flaggedRevs.advanced and ext.flaggedRevs.review on mobile

https://gerrit.wikimedia.org/r/817927

gerritbot added a comment.Jul 28 2022, 8:15 AM

Change 817927 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Enable ext.flaggedRevs.advanced and ext.flaggedRevs.review on mobile

https://gerrit.wikimedia.org/r/817927

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).Jul 28 2022, 9:00 AM
Jdlrobson mentioned this in T307909: Investigate feasibility of modifying the display of individual preferences on mobile web [8hr].Aug 4 2022, 8:56 AM
Jdlrobson mentioned this in T257143: Clean up the technical debt and inconsistencies of notification icon (Echo badge) positioning in different skins.Nov 19 2022, 12:32 AM
gerritbot added a comment.Nov 21 2022, 11:27 PM

Change 859150 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DarkMode@master] Dark mode code should load on mobile and desktop targets

https://gerrit.wikimedia.org/r/859150

Jdlrobson mentioned this in T323542: Forbid new modern code from not targeting mobile.Nov 21 2022, 11:29 PM
gerritbot added a comment.Nov 21 2022, 11:34 PM

Change 859151 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/TemplateSandbox@master] Mixing packageFiles and targets should not be allowed

https://gerrit.wikimedia.org/r/859151

gerritbot added a comment.Nov 21 2022, 11:52 PM

Change 859152 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Remove mobile-only modules

https://gerrit.wikimedia.org/r/859152

gerritbot added a comment.Nov 22 2022, 8:09 PM

Change 859609 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] All modules should target both mobile and desktop targets

https://gerrit.wikimedia.org/r/859609

gerritbot added a comment.Nov 23 2022, 1:23 AM

Change 859642 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Should be possible to load mediawiki upload modules on mobile domain

https://gerrit.wikimedia.org/r/859642

gerritbot added a comment.Nov 23 2022, 2:50 AM

Change 859648 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Disambiguator@master] Load ext.disambiguator on mobile

https://gerrit.wikimedia.org/r/859648

gerritbot added a comment.Nov 23 2022, 3:12 AM

Change 859650 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Remove desktop only es6 modules

https://gerrit.wikimedia.org/r/859650

Michael added a subscriber: Michael.Nov 23 2022, 10:52 AM
gerritbot added a comment.Nov 23 2022, 11:23 AM

Change 859642 merged by jenkins-bot:

[mediawiki/core@master] resources: Should be possible to load upload modules on mobile

https://gerrit.wikimedia.org/r/859642

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 23 2022, 12:00 PM
gerritbot added a comment.Nov 24 2022, 6:46 AM

Change 859152 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Remove desktop only es6 modules

https://gerrit.wikimedia.org/r/859152

gerritbot added a comment.Nov 30 2022, 5:53 PM

Change 859650 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Make es6 modules available on all targets

https://gerrit.wikimedia.org/r/859650

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.13; 2022-12-05); removed MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 30 2022, 6:00 PM
gerritbot added a comment.Dec 5 2022, 7:21 PM

Change 859150 merged by jenkins-bot:

[mediawiki/extensions/DarkMode@master] Dark mode code should load on mobile and desktop targets

https://gerrit.wikimedia.org/r/859150

Jdlrobson mentioned this in rEDKMd7ee54f8dc8a: Dark mode code should load on mobile and desktop targets.Dec 5 2022, 7:22 PM
gerritbot added a comment.Dec 5 2022, 7:41 PM

Change 859648 merged by jenkins-bot:

[mediawiki/extensions/Disambiguator@master] Add mobile target to ext.disambiguator

https://gerrit.wikimedia.org/r/859648

Jdlrobson mentioned this in rEDIS8c9c993d1da2: Add mobile target to ext.disambiguator.Dec 5 2022, 7:42 PM
Jdlrobson closed subtask T323542: Forbid new modern code from not targeting mobile as Declined.Dec 7 2022, 3:28 AM
Jdlrobson closed subtask T235712: Fix the most common "Module not loadable on target mobile" warnings (Oct 2019) as Resolved.Dec 8 2022, 12:48 AM
Jdlrobson added a subtask: T324723: Fix the most common "Module not loadable on target mobile" warnings (December 2022).Dec 8 2022, 12:57 AM
gerritbot added a comment.Dec 8 2022, 1:13 AM

Change 865811 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] ResourceLoader: Default modules to mobile and desktop targets

https://gerrit.wikimedia.org/r/865811

Mainframe98 awarded a token.Dec 8 2022, 8:17 PM
gerritbot added a comment.Dec 12 2022, 10:28 PM

Change 867283 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Set targets explicitly on desktop only module

https://gerrit.wikimedia.org/r/867283

gerritbot added a comment.Dec 12 2022, 10:34 PM

Change 867285 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Flow@master] ext.flow.visualEditor targets desktop explicitly

https://gerrit.wikimedia.org/r/867285

gerritbot added a comment.Dec 12 2022, 10:40 PM

Change 867287 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Set targets explicitly

https://gerrit.wikimedia.org/r/867287

gerritbot added a comment.Dec 13 2022, 6:45 PM

Change 867285 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] ext.flow.visualEditor targets desktop explicitly

https://gerrit.wikimedia.org/r/867285

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 13 2022, 7:00 PM
gerritbot added a comment.Dec 14 2022, 4:43 AM

Change 867287 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Set targets explicitly

https://gerrit.wikimedia.org/r/867287

gerritbot added a comment.Dec 14 2022, 5:35 AM

Change 867283 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set targets explicitly on desktop only module

https://gerrit.wikimedia.org/r/867283

gerritbot added a comment.Dec 14 2022, 5:46 PM

Change 868140 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] QUnit test module should explicitly target desktop

https://gerrit.wikimedia.org/r/868140

gerritbot added a comment.Dec 14 2022, 5:47 PM

Change 868141 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Set QUnit test module to target desktop explicitly

https://gerrit.wikimedia.org/r/868141

gerritbot added a comment.Dec 14 2022, 6:40 PM

Change 859609 abandoned by Jdlrobson:

[mediawiki/extensions/VisualEditor@master] All modules should target both mobile and desktop targets

Reason:

Thanks! Yeh https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/867283 should unblock changing the default targets.

https://gerrit.wikimedia.org/r/859609

gerritbot added a comment.Dec 14 2022, 6:46 PM

Change 868140 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] QUnit test module should explicitly target desktop

https://gerrit.wikimedia.org/r/868140

gerritbot added a comment.Dec 14 2022, 7:47 PM

Change 859151 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Don't prevent the VisualEditor plugin from loading on mobile

https://gerrit.wikimedia.org/r/859151

gerritbot added a comment.Dec 14 2022, 7:52 PM

Change 868141 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Set QUnit test module to target desktop explicitly

https://gerrit.wikimedia.org/r/868141

Jdlrobson mentioned this in rETSA62758886d881: Don't prevent the VisualEditor plugin from loading on mobile.Dec 14 2022, 8:13 PM
alistair3149 added a subscriber: alistair3149.Dec 17 2022, 7:35 PM
Tgr mentioned this in T286138: Cannot use NFC security keys with WebAuthn on iOS.Dec 21 2022, 10:54 PM
larissagaulia moved this task from To-do: Goals, prioritized next 4 Quarters to Backlog: Future Goals, non-prioritized on the Performance-Team board.Jan 19 2023, 1:17 PM
Lucas_Werkmeister_WMDE closed subtask T326405: Make target of desktop-only Wikibase modules explicit as Resolved.Jan 31 2023, 3:45 PM
gerritbot added a comment.Jan 31 2023, 9:17 PM

Change 865811 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Default File modules to mobile and desktop targets

https://gerrit.wikimedia.org/r/865811

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 31 2023, 10:00 PM
Jdlrobson closed subtask T324723: Fix the most common "Module not loadable on target mobile" warnings (December 2022) as Resolved.Jan 31 2023, 10:37 PM
kostajh added a subtask: T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions.Feb 1 2023, 10:27 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 10:32 AM
gerritbot added a comment.Feb 1 2023, 10:47 AM

Change 885788 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] Adjust default targets in RL/Module

https://gerrit.wikimedia.org/r/885788

gerritbot added a project: Patch-For-Review.Feb 1 2023, 10:47 AM
gerritbot added a comment.Feb 1 2023, 11:01 AM

Change 885793 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] ResourceLoader: Define targets in a single location

https://gerrit.wikimedia.org/r/885793

Jdlrobson added a comment.EditedFeb 1 2023, 8:53 PM

Not doing this for ResourceLoaderModule was somewhat intentional to limit scope and impact of the change - it seems in the PageTriage case, a RL\FileModule is depending on a RL\WikiModule (which I believe is quite a rare situation). The change in https://gerrit.wikimedia.org/r/885793 would change the defaults for WikiModules as well as anything using Module directly.

In terms of Module: it is only used in https://codesearch.wmcloud.org/deployed/?q=extends%20ResourceLoaderModule&i=nope&files=&excludeFiles=&repos=
I'm not too worried about this, as I think the only thing this would effect is CurrencyRatesModule (the others explicitly set targets)

In terms of WikiModule however I see this as pretty risky. Codesearch returns these impacts modules as well as all the core styles/scripts modules.

https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiLove/+/43fe2a66447de583fdc2bb38bfec1f306908f4ab/extension.json#222
and https://gerrit.wikimedia.org/g/mediawiki/extensions/Gadgets/+/a7523dca5638a89cf0ad035201e71cd664920549/includes/GadgetResourceLoaderModule.php#12

The latter seems pretty risky, since it could lead to a lot of untested gadget code being unleashed on mobile so I think if we do the core change, we should also cautiously set gadgets (see also reply to wikitech-l thread)

I think we should eventually do this core change, but should likely make this happen in a later iteration.

I'd therefore advise we do the following:

  1. Merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/885881 that should unblock code changes in the PageTriage extension. Identify other issues in our our code.
  2. Let next weeks' train roll out. Monitor logs for any other problems.
  3. Run a User-notice about https://gerrit.wikimedia.org/r/885793
  4. Merge https://gerrit.wikimedia.org/r/885793 when user notice has been seen and community have had enough time to comment.

How does that sound?

kostajh added a comment.Feb 1 2023, 8:59 PM
In T127268#8580111, @Jdlrobson wrote:

Not doing this for ResourceLoaderModule was somewhat intentional to limit scope and impact of the change - it seems in the PageTriage case, a RL\FileModule is depending on a RL\WikiModule (which I believe is quite a rare situation). The change in https://gerrit.wikimedia.org/r/885793 would change the defaults for WikiModules as well as anything using Module directly.

In terms of Module: it is only used in https://codesearch.wmcloud.org/deployed/?q=extends%20ResourceLoaderModule&i=nope&files=&excludeFiles=&repos=
I'm not too worried about this, as I think the only thing this would effect is CurrencyRatesModule (the others explicitly set targets)

In terms of WikiModule however I see this as pretty risky. Codesearch returns these impacts modules as well as all the core styles/scripts modules.

https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiLove/+/43fe2a66447de583fdc2bb38bfec1f306908f4ab/extension.json#222
and https://gerrit.wikimedia.org/g/mediawiki/extensions/Gadgets/+/a7523dca5638a89cf0ad035201e71cd664920549/includes/GadgetResourceLoaderModule.php#12

The latter seems pretty risky, since it could lead to a lot of untested gadget code being unleashed on mobile so I think if we do the core change, we should also cautiously set gadgets (see also reply to wikitech-l thread)

I think we should eventually do this core change, but should likely make this happen in a later iteration.

I'd therefore advise we do the following:

  1. Merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/885881 that should unblock code changes in the PageTriage extension. Identify other issues in our our code.
  2. Let next weeks' train roll out. Monitor logs for any other problems.
  3. Run a User-notice about https://gerrit.wikimedia.org/r/885793
  4. Merge https://gerrit.wikimedia.org/r/885793 when user notice has been seen and community have had enough time to comment.

How does that sound?

That sounds reasonable, thank you for thinking through the implications of that for gadget code.

Jdlrobson added a subtask: T328610: Default gadgets to run on mobile.Feb 1 2023, 10:10 PM

Okay I've prepared for 3. I'll make sure that happens at earliest opportunity.

Jdlrobson added a comment.EditedFeb 1 2023, 10:49 PM

@Catrope has pointed out that gadgets will not be impacted by this change because the targets definition comes from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Gadgets/+/a7523dca5638a89cf0ad035201e71cd664920549/includes/Gadget.php#62

So actually the core change should be relatively safe - only CurrencyRatesModule and Wikilove. I have therefore rescinded my review.

gerritbot added a comment.Feb 1 2023, 11:57 PM

Change 885788 merged by jenkins-bot:

[mediawiki/core@master] Adjust default targets in RL/Module

https://gerrit.wikimedia.org/r/885788

gerritbot added a comment.Feb 2 2023, 4:43 PM

Change 885793 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Define targets in a single location

https://gerrit.wikimedia.org/r/885793

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 5:31 PM
Jdlrobson mentioned this in T325585: 1.40.0-wmf.22 deployment blockers.Feb 2 2023, 9:58 PM
Jdlrobson closed subtask T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions as Resolved.Feb 6 2023, 10:46 PM
gerritbot added a comment.Feb 14 2023, 1:02 AM

Change 888816 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] WIP: Error for any module that introduces bad targets

https://gerrit.wikimedia.org/r/888816

gerritbot added a project: Patch-For-Review.Feb 14 2023, 1:02 AM
gerritbot added a comment.Fri, Mar 3, 7:20 PM

Change 271462 abandoned by Jforrester:

[mediawiki/core@master] resourceloader: Include mobile in default FileModule targets

Reason:

Done in Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb.

https://gerrit.wikimedia.org/r/271462

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL