Page MenuHomePhabricator

Provide license name (or more specific icons) in app
Closed, ResolvedPublic

Description

Stop using the categorization icon system:

License_Icon_Legend.png (470×1 px, 18 KB)

It is possible to extract the exact license info from https://www.mediawiki.org/wiki/API:Imageinfo, and then we can provide the correct license icons for CC-BY-SA (all 3 icons, not just CC, since that means nothing)
Affected, related task: T126884, T126667, T100335 and T127366)

Related Objects

Event Timeline

JMinor moved this task from Backlog to Needs Design on the iOS-app-v5.1.0-Saturn board.
RHo added subscribers: JMinor, RHo.

hi @JMinor - just wanted to clarify how to proceed.

In an old related ticket T101534: Extract exact license info for share a fact cards – it was determined that we would show just one 'category' icon from the three category icons (CC, Public Domain, Fair use) on the share-a-fact card, rather than currently in iOS showing incorrectly 3 icons for (CC)-(BY)-(SA) all the time (even when it is not the case).

It looks like this ticket is asking to abandon this categorization system and to now now specify the 3 separate icons if it is CC, per the separate icons here everywhere where images are shown with license info in the app.

Since this hinges on the feasibility of being able to extra the entire licence info, can we get confirmation that this is now indeed possible before proceeding?

If feasible, let's close the conflicting existing ticket T101534 since this seemed partly based on the inability for the full license from being extracted(?).

Also we should then file an equivalent ticket on Android (since they have already implemented the 'category' system per T101436).

Assigning to me to clarify requirements/conflicting tasks.

The intention of creating this ticket was to specify the different licenses in the apps Gallery Image view, so that even when offline the license is visible and 'understandable'.

The Share-A-Fact cards is a whole other clusterfuck if I may say so...

Lets set aside Share-a-fact for now, since it is, as you say a clusterfuck, not just for licensing but for other technical and UX reasons.

I'd like to make some improvement in the gallery at least.

Do these requirements clarify whats needed?

When a user is on the full screen gallery use the creative commons provided icons to specify the licensing terms of the image. These icons should tap through to the creative commons page where the license info.

Do these requirements clarify whats needed?

When a user is on the full screen gallery use the creative commons provided icons to specify the licensing terms of the image. These icons should tap through to the creative commons page where the license info.

For Creative Commons licenses, that would satisfy my liking at least.

pasted_file (64×64 px, 2 KB)
pasted_file (64×64 px, 2 KB)

However what to do if only licensed under e.g. {{GFDL}} or "Free Art License" I'm not sure, since the current way of displaying a "bookmark"(?) icon is not good...
Displaying icons for those as well could perhaps be made (as a separate ticket), and limit this ticket to display better icons for Creative Commons licenses.

Heckert_GNU_white.svg.png (63×64 px, 5 KB)
pasted_file (44×124 px, 5 KB)

Thanks.

I'd prefer to avoid adding the GFDL and Free Art icons, since they are a bit more branded and inelegant than the CC ones. @RHo any thoughts on how to make them visually not so egregious? Maybe just use the strings "GFDL Licensed" or "Free Art License"?

Just a thought. Why not just add the licenses as a reference drawers, and when pressed on e.g. a text that says "License" at the bottom, a drawer could "pop out" and we could display the same license templates as on Commons...(e.g {{self|cc-by-sa-3.0|gfdl}} (table class *licensetpl*) Then we could both have it be visually good looking, and provide multiple licenes if dual-licensensed and display "terms" inside the app...but that's might be a thing for 5.3 or 6.0 or something....

The specific GFDL license artwork is actually "GFDL" contained in a ribbon

Actual GDFL logo (54×175 px, 7 KB)

(from: https://www.gnu.org/graphics/license-logos.html)

Since it is not as distinctively branded as the using the Gnu logo, we can go with one of the following two options.

(a) Single simplified ribbon logo with appropriate string next to the logo

Example - ribbon icon applied across all free and fair use image licenses (68×705 px, 9 KB)

(b) Simplified versions of each of the GFDL, LFDL, FAL and Fair use artwork

Example - separate icons for different free and fair use image licenses (99×566 px, 8 KB)

I would recommend (a) as it is simple and would render much better in the small sizes where it is displayed over images.

I've attached the following assets as a folder of SVGs and PDFs.

Image license icons (274×519 px, 20 KB)

Assets

Are you planning on using the same icon for PD as with CC-Zero? Otherwise, I'm missing

pasted_file (2×2 px, 168 KB)

thanks @Josve05a – just updated with asset pack with the missing cc-zero icon.

JMinor raised the priority of this task from Low to Medium.Sep 12 2016, 6:40 PM

@RHo option a) looks good to me.

Acceptance criteria:

  • All images should show an icon to indicate their license (see icon pack) in the gallery view
  • Tapping the icon should open to the liscense/information page in the in-app browser (as in the article footer for cc-by-sa text)
  • If no license info is available, show no icon

Per our meeting today, if we can get this into share-a-fact without significant extra effort, please do.

Hey @Dbrant, we are finally fixing our long overdue license indicators on images.

Android has already done the core of this, but @RHo has created some additional icons for licenses that were not covered by (cc), if you guys want to expand your coverage/accuracy for attribution.

@Josve05a do you have more examples of images with GFDL and FAL licensing? The Germany image is too small for the gallery and Dew on a Leaf doesn't seem to appear in any articles. So specifically, looking for articles that contain large images with GFDL and/or FAL licensing. Thanks!

@RHo could I get the inverted versions of these icons (just the PDFs are fine) thanks!

@Josve05a do you have more examples of images with GFDL and FAL licensing? The Germany image is too small for the gallery and Dew on a Leaf doesn't seem to appear in any articles. So specifically, looking for articles that contain large images with GFDL and/or FAL licensing. Thanks!

@JMinor @RHo - I'm not seeing icons for GFDL or FAL either - also, it looks like there are some cases where the license differs for commercial/non commercial use. How do we want to handle licenses we can't represent with the icons we have app side?

Hi @JoeWalsh

In T127377#2613183, @RHo wrote:
(a) Single simplified ribbon logo with appropriate string next to the logo

Example - ribbon icon applied across all free and fair use image licenses (68×705 px, 9 KB)

As for images where the license differs for commercial/NC use, we are displaying it in the app for non-commercial use so that would be the license logo displayed. It would only be upon tapping on the info that the user gets to the specific commons link with the additional permissions information.
This is what I have surmised according to the Weevil image example posted in web and mobile web versions on the en article. May be worthwhile checking from legal.

(https://commons.wikimedia.org/wiki/File:Long_nosed_weevil_edit.jpg should display the GFDL-icon in-app, since that is the "free license" which is allowed. Other licenses which limits to NC are "extra", but the GFDL is the main license for that one, per COM:L.)

@RHo Thanks! I missed that comment and the acceptance criteria- my bad.

Could I get versions of the icons with the colors inverted for use in the gallery?

here you go @JoeWalsh – re-exported cleaner versions of the black as well.

These look awesome @JoeWalsh
Hopefully an easy change, but I've attached an updated version of the more info "i" icon as well below so that the sizes match with these new image license icons :)

I'd suggest adding a dash between "GFDL 1.2" and the author name.
[edit] in this example below I'd like for some separation between the license and the author, so nobody things 1.2 is part of the author name.

pasted_file (1×640 px, 952 KB)

@Josve05a [edit] never mind - misread the comment. That's a question for @RHo and @JMinor

This comment was removed by Josve05a.

@JoeWalsh – Let's add a "•" (Bullet Unicode U+2022) as the separator between the GFDL licence text and the author name, as per usage in mobile web fullscreen view of images.

Artboard.png (1×640 px, 986 KB)

Testing Criteria:

  1. Search for the article for "Barack Obama" on English Wikipedia and tap on the result to view.
  2. Tap on the image at the top of the article
  3. Swipe right five times through the first six images
  4. Verify that the license icons show with the images as in the following screenshots (the screenshots here are out of order, match the actual image with the license icons):

Simulator Screen Shot Oct 4, 2016, 2.38.35 PM.png (1×750 px, 1 MB)

Simulator Screen Shot Oct 4, 2016, 2.38.38 PM.png (1×750 px, 665 KB)

Simulator Screen Shot Oct 4, 2016, 2.38.46 PM.png (1×750 px, 1 MB)

Simulator Screen Shot Oct 4, 2016, 2.38.40 PM.png (1×750 px, 833 KB)

Simulator Screen Shot Oct 4, 2016, 2.38.47 PM.png (1×750 px, 640 KB)

Simulator Screen Shot Oct 4, 2016, 2.38.48 PM.png (1×750 px, 570 KB)

Simulator Screen Shot Oct 4, 2016, 2.38.44 PM.png (1×750 px, 145 KB)

Testing on iPhone 6s (iOS 10.0.1) with Wikipedia app 5.3.0 (956). This is fixed as the Barack Obama image gallery matches the @JoeWalsh screencaps above.

@Josve05a

happy?

Yes, very :)
Only one small thing, which can be seperated to a different ticket. On this article, this image is diplaying an "other icon" with the license being "PD-US". Anyway to get the PD-icon for that?

Created T147865 for the PD-US issue.

If you note any other miss-tagging please file follow up tickets.