Page MenuHomePhabricator
Create Task
Maniphest T127682

Make code editor understand JSON with comments and trailing commas
Open, Needs TriagePublic
Actions

Description

MediaWiki uses a more relaxed form of JSON that permits both // style comments and unneeded trailing commas. But codeeditor that we use to edit that json shows error on the first comment or comma, and does not show any real errors. This is especially evident when designing a new graph in https://en.wikipedia.org/wiki/Special:GraphSandbox

Related Objects

Event Timeline

Yurik created this task.Feb 22 2016, 4:24 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 22 2016, 4:24 AM
TheDJ added a project: Upstream.Feb 22 2016, 8:46 PM
TheDJ subscribed.

This will need to be filed with the Ace project.

TheDJ merged a task: T148930: Support extended json syntax in CodeEditor .Feb 9 2020, 7:26 PM
IKhitron awarded a token.May 19 2021, 5:08 PM
IKhitron subscribed.
diegodlh subscribed.Mar 31 2022, 4:56 PM

Comments and trailing commas are supported in JSON5, and JSON5 support seems to have been added to Ace in 2019.

diegodlh mentioned this in T305571: Configure JsonConfig for pattern Web2Cit/data/**/*.json in metawiki's "Main" namespace.Apr 6 2022, 5:30 PM
Jasonkhanlar mentioned this in T302694: Consider supporting JSON5 and YAML configuration files.May 11 2022, 3:20 AM
Tomastvivlaren awarded a token.Jul 10 2025, 12:08 AM
Tomastvivlaren subscribed.
Tomastvivlaren added a comment.Jul 10 2025, 12:12 AM

Automatically fixing missing and trailing commas when the user saves the page is really simple. Please keep in mind that beginners edit the Data pages manually and can easily make mistakes. The error message "Syntax error" is not very informative.

Nirmos subscribed.Mar 22 2026, 4:26 AM
Bhsd added a project: MediaWiki-extensions-CodeMirror.May 20 2026, 6:35 PM
Bhsd subscribed.

Since JSON syntax highlighting is now using CodeMirror on WMF sites, this task is also relevant to CodeMirror.

Bhsd moved this task from Backlog to Improvement on the MediaWiki-extensions-CodeMirror board.May 23 2026, 7:13 PM
Mr._Starfleet_Command subscribed.Jun 3 2026, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits