Page MenuHomePhabricator
Create Task
Maniphest T12769

Database::update() should return the result
Closed, ResolvedPublic
Actions

Description

Author: thomas.dalton

Description:
at return statement to Database::update()

Database::update() should return the result of the query (true for success, false for failure), but doesn't. This patch fixes that (just the addition of one word).

Version: unspecified
Severity: enhancement

Attached:

databasereturn.patch385 BDownload

Details

Reference
bz10769

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:49 PM
• bzimport added a project: MediaWiki-libs-Rdbms.
• bzimport set Reference to bz10769.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Aug 1 2007, 9:37 PM
• bzimport added a comment.Aug 1 2007, 9:40 PM

robchur wrote:

Note that the boolean alone won't be enough to determine whether or not rows were updated at all; database errors tend to throw exceptions, which should be caught, or passed up, but the more useful check is to call Database::affectedRows().

• bzimport added a comment.Aug 1 2007, 9:43 PM

robchur wrote:

Fixed in r24532.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits