DomainException on Special:Notifications on mediawiki.org
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dereckson
	Feb 22 2016, 5:37 PM

Description

https://www.mediawiki.org/wiki/Special:Notifications -> Exception encountered, of type "DomainException"

Echo icon -> Could not retrieve notifications. Please try again. (Error [1bb1d3ad] Exception Caught: No agent associated with notification with id '52564' of type 'edit-thank')

2016-02-22 17:36:32 mw1200 mediawikiwiki 1.27.0-wmf.13 exception ERROR: [1bb1d3ad] /w/api.php?action=query&format=json&notsections=alert&meta=notifications&notgroupbysection=1&notmessageunreadfirst=1&notformat=model&notlimit=25&notprop=index%7Clist%7Ccount&uselang=en&_=1456162588213   DomainException from line 285 of /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/formatters/EventPresentationModel.php: No agent associated with notification with id '52564' of type 'edit-thank' {"exception_id":"1bb1d3ad"}
[Exception DomainException] (/srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/formatters/EventPresentationModel.php:285) No agent associated with notification with id '52564' of type 'edit-thank'
  #0 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Thanks/ThanksPresentationModel.php(29): EchoEventPresentationModel->getAgentLink()
  #1 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/formatters/EventPresentationModel.php(381): EchoThanksPresentationModel->getSecondaryLinks()
  #2 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/formatters/EchoModelFormatter.php(13): EchoEventPresentationModel->jsonSerialize()
  #3 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/formatters/EchoEventFormatter.php(30): EchoModelFormatter->formatModel(EchoThanksPresentationModel)
  #4 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/DataOutputFormatter.php(141): EchoEventFormatter->format(EchoEvent)
  #5 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/DataOutputFormatter.php(116): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, Language)
  #6 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/api/ApiEchoNotifications.php(219): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, Language)
  #7 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/api/ApiEchoNotifications.php(129): ApiEchoNotifications->getPropList(User, array, array, integer, NULL, string, boolean)
  #8 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Echo/includes/api/ApiEchoNotifications.php(49): ApiEchoNotifications->getSectionPropList(User, string, array, integer, NULL, string, boolean)
  #9 /srv/mediawiki/php-1.27.0-wmf.13/includes/api/ApiQuery.php(277): ApiEchoNotifications->execute()
  #10 /srv/mediawiki/php-1.27.0-wmf.13/includes/api/ApiMain.php(1319): ApiQuery->execute()
  #11 /srv/mediawiki/php-1.27.0-wmf.13/includes/api/ApiMain.php(461): ApiMain->executeAction()
  #12 /srv/mediawiki/php-1.27.0-wmf.13/includes/api/ApiMain.php(433): ApiMain->executeActionWithErrorHandling()
  #13 /srv/mediawiki/php-1.27.0-wmf.13/api.php(83): ApiMain->execute()
  #14 /srv/mediawiki/w/api.php(3): include(string)
  #15 {main}

Details

	Subject	Repo	Branch	Lines +/-
	Handle null user when trying to generate a link for notifications	mediawiki/extensions/Echo	master	+6 -2

Customize query in gerrit

Related Objects

Mentioned In: T128020: [betalabs] "Thank action failed" message
Mentioned Here: T128020: [betalabs] "Thank action failed" message

Event Timeline

Dereckson created this task.Feb 22 2016, 5:37 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 22 2016, 5:37 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript

hoo updated the task description. (Show Details)Feb 22 2016, 5:39 PM

hoo removed a project: SRE.

• Mattflaschen-WMF triaged this task as High priority.Feb 22 2016, 9:22 PM

• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.

The code that produced this exception doesn't exist anymore since https://gerrit.wikimedia.org/r/#/c/271297

I never thought the agent could be null. Since it can, we could return null from getUserLink or check it in canRender and suppress the notification entirely.

Catrope moved this task from Untriaged to RFP (Special:Notifications) on the Collaboration-Team-Archive-2015-2016 board.Feb 23 2016, 9:54 PM

Change 272998 had a related patch set uploaded (by Sbisson):
Handle null user when trying to generate a link for notifications

https://gerrit.wikimedia.org/r/272998

gerritbot added a project: Patch-For-Review.Feb 24 2016, 4:43 PM

SBisson claimed this task.Feb 24 2016, 4:43 PM

SBisson moved this task from RFP (Special:Notifications) to Needs Review on the Collaboration-Team-Archive-2015-2016 board.

SBisson moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Feb 24 2016, 9:26 PM

Change 272998 merged by jenkins-bot:
Handle null user when trying to generate a link for notifications

https://gerrit.wikimedia.org/r/272998

SBisson moved this task from Code Review Started to QA Review on the Collaboration-Team-Archive-2015-2016 board.Feb 24 2016, 9:30 PM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 24 2016, 10:00 PM

Etonkovidova mentioned this in T128020: [betalabs] "Thank action failed" message .Feb 25 2016, 8:36 PM

Checked in betalabs - did not see exceptions for 'edit-thank' . T128020: [betalabs] "Thank action failed" message was probably fixed due to this fix.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Feb 25 2016, 8:56 PM

• jmatazzoni closed this task as Resolved.Feb 26 2016, 6:27 PM

DomainException on Special:Notifications on mediawiki.orgClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

DomainException on Special:Notifications on mediawiki.org
Closed, ResolvedPublic
Actions