Page MenuHomePhabricator

[Regression wmf.14] Personal tools z-index are showing above OOUI dialogs
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Open a page with VE
  2. Open a Media Settings/Add Template dialog

Observe that , the header area of the dialog seems transparent, the navigation links on top of the page are showing through it.

Event Timeline

Jdforrester-WMF renamed this task from [Regression wmf.14] Page navigation links are showing through the header of all dialogs to [Regression wmf.14] Personal tools z-index are showing above OOUI dialogs.Feb 23 2016, 8:15 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added projects: OOUI, Vector.
Jdforrester-WMF set the point value for this task to 1.

I'm pretty sure I fixed this bug at least three times in the past, and @Esanders fixed it once or twice too.

This'd be because @Esanders removed the hack that accounted for Vector's high #p-personal z-index in efd41fbc74dd24874a79dbe0c29443bc03dc83c4. That commit says that Vector should have had its z-index fixed, but presumably that hasn't actually rolled out?

This'd be because @Esanders removed the hack that accounted for Vector's high #p-personal z-index in efd41fbc74dd24874a79dbe0c29443bc03dc83c4. That commit says that Vector should have had its z-index fixed, but presumably that hasn't actually rolled out?

The Vector fix was 1cce1de1be93ed7fdad00155d117596d11402e73 and was rolled out at the same time, but apparently isn't working.

I'd guess that "+oojs-ui.styles": "skinStyles/ooui.less", is failing to trigger ooui.less's inclusion on VE pages, though I'm not actually familiar enough with ResourceLoader to know quite where the fix for that should lie.

Argh, we renamed that module…

Change 273931 had a related patch set uploaded (by DLynch):
oojs-ui.styles is now oojs-ui-core.styles

https://gerrit.wikimedia.org/r/273931

Change 273931 merged by jenkins-bot:
oojs-ui.styles is now oojs-ui-core.styles

https://gerrit.wikimedia.org/r/273931