Page MenuHomePhabricator

ParserOutput: Fix semantics of getText() to return text; Introduce getExpandedText (bikeshed name in comments) to return processed text with edit links + toc, etc.
Open, MediumPublic

Description

In T124356#1954680, @tstarling pointed out that 969561ae3c9051eb408626e9b6debb6c0f210b71 broke the semantics of ParserOutput::getText(). This ticket proposes that we fix that breakage.

All users, by default, should receive unprocessed text without skin-specific section edit links and TOC. Any callsite that needs the fully expanded text should explicitly request it with the new method to be introduced (getExpandedText, or whatever it is).

This can prevent newer instances of T124356.

Event Timeline

ssastry created this task.Feb 22 2016, 9:43 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 22 2016, 9:43 PM
ssastry renamed this task from ParserOutput: Change semantics of getText() to return text; Introduce getExpandedText (bikeshed in comments) to return processed text with edit links + toc, etc. to ParserOutput: Change semantics of getText() to return text; Introduce getExpandedText (bikeshed name in comments) to return processed text with edit links + toc, etc..Feb 22 2016, 9:44 PM
ssastry renamed this task from ParserOutput: Change semantics of getText() to return text; Introduce getExpandedText (bikeshed name in comments) to return processed text with edit links + toc, etc. to ParserOutput: Fix semantics of getText() to return text; Introduce getExpandedText (bikeshed name in comments) to return processed text with edit links + toc, etc..Feb 23 2016, 10:09 PM

@tstarling seems on board with call-sites explicitly opt-ing into getting fully processed output. However, he had more specific ideas about how this processing would be done that goes beyond the interface stub in the title of the ticket. I'll let him document the specifics here.

ssastry triaged this task as Medium priority.Jan 5 2017, 10:58 PM
cscott added a subscriber: cscott.Nov 28 2017, 4:32 PM