A few bug fixes came out of the AQS deployment. Would like to get them packaged up and deployed on the servers. Newest deployment tag at: https://phabricator.wikimedia.org/diffusion/MSCA/browse/master/;3.0.2
- Mentioned In
- T161832: Portals deployment failed
T127828: scap3 upstream/debian versioning
- Mentioned Here
- rMSCAf78caf877875: Update changelog for Debian version 3.5.4-1
rMSCA7a2395a559ee: Bump debian version 3.5.3-1
rMSCA88a53c885f64: Update debian changelog for 3.5.2-1
P4808 scap 3.5.0-1 changelog (maybe)
T152390: scap sync-l10n AttributeError: 'Namespace' object has no attribute 'message'
P4523 scap changelog for 3.3.1 and 3.4.0
T150897: Env vars being overwritten
T134156: Allow per-environment scap.cfg overrides
T145373: Local config deploys should use the target's current version
T144244: Tab completion doesn't work well for directories
T145194: Scap fails to force-deploy the config
T142990: Sequential execution should be per-deployment, not per-phase
T142364: TypeError: unsupported operand type(s) for %: 'dict' and 'tuple'
T142792: Failed to rollback scap3 deployment
T128414: i18n changes not taking effect on Beta Cluster
I've uploaded scap 3.0.2-1 to carbon
This time was trickier than usual because master isn't at 3.0.2 afaics?
anyway to convince git-buildpackage to DTRT in this case you have to be in a branch so I git checkout -b debian 3.0.2
also going forward we should make more obvious what's the process to bump versions, ATM setup.py version is never changed, IOW we're assuming scap3 will be only distributed via debian packages.
* 91cdbe4 - (HEAD -> master, origin/master, origin/HEAD) Add coverage for current link replacement (Mon Feb 22 17:13:56 2016 -0800) <Dan Duvall> | * e786a9b - (tag: 3.0.2) Update changelog for bugfix package bump (Mon Feb 22 13:25:00 2016 -0800) <Tyler Cipriani> |/ * 2332ad0 - Treat linked dirs as link target as normal file (Mon Feb 22 12:49:16 2016 -0800) <Tyler Cipriani> * 603ef0c - Only sudo when actually necessary (Mon Feb 22 11:54:54 2016 -0800) <Dan Duvall> * a593285 - Compare cdb mtimes less granularly (Fri Feb 19 14:07:32 2016 -0800) <Tyler Cipriani> * 2a2a5b5 - Default to the effective user in scap.Context (Mon Feb 15 10:50:56 2016 -0800) <Dan Duvall> * 8289e30 - (tag: debian/3.0.1-1) I incorrectly tagged 3.0.1, updating changelog again (Mon Feb 15 09:12:47 2016 -0600) <Mukunda Modell> * 31727c0 - updated changelog. (Mon Feb 15 06:03:47 2016 -0600) <Mukunda Modell> * c3d4de8 - (tag: 3.0.1) Add refreshCdbJsonFiles to the scap.deb package (Fri Feb 12 12:10:42 2016 -0600) <Mukunda Modell> * 2d4b633 - Socket has no fqdn method (Thu Feb 11 14:42:31 2016 -0800) <Tyler Cipriani> * d836f57 - Canonicalize host names when excluding hosts (Thu Feb 11 12:52:29 2016 -0800) <Dan Duvall> * 459247b - (tag: debian/3.0-1, tag: 3.0) Remove `git_repo_user` configuration (Fri Jan 29 10:35:23 2016 -0800) <Dan Duvall>
Yup 3.0.2 tag is a fork of master apparently.
Looking at scap, it lacks a configuration file for git-buildpackage debian/gbp.conf so it will end up using the master for the Debian branch but build the tarball from the tag. Note how there is a debian/3.0.1-1 which is potentially recognized by gbp out of the box. It has:
--git-debian-tag=DEBIAN_TAG Format string for debian tags, default is 'debian/%(version)s'
New tag should be at 3.0.3:
scap master[git]✔ 14s (ﾉ^ヮ^)ﾉ*:・ﾟ✧ git lol * 697f198 (HEAD -> master, tag: 3.0.3, origin/master, origin/HEAD) Update changelog for bugfix package bump
@thcipriani I've uploaded 3.0.3-1 with a couple of minor changes to debian/changelog
root@carbon:~# reprepro list jessie-wikimedia scap jessie-wikimedia|main|amd64: scap 3.0.3-1 jessie-wikimedia|main|i386: scap 3.0.3-1 jessie-wikimedia|main|source: scap 3.0.3-1 root@carbon:~# reprepro list trusty-wikimedia scap trusty-wikimedia|main|amd64: scap 3.0.3-1 trusty-wikimedia|main|i386: scap 3.0.3-1 trusty-wikimedia|main|source: scap 3.0.3-1
I have a bugfix release for scap. Tagged debian/3.2.3-1 and pushed up to the repo. This one should fix T142792: Failed to rollback scap3 deployment and T142364: TypeError: unsupported operand type(s) for %: 'dict' and 'tuple'
Thanks for all your help!
@fgiunchedi could I get you to upload scap_3.2.5-1 to carbon?
New release should fix up T145194: Scap fails to force-deploy the config, T144244: Tab completion doesn't work well for directories, and add a few other backwards-compaitble compatible niceties :)
@fgiunchedi could I get you to upload scap_3.3.0-1 to carbon?
Version contains fixes for T134156: Allow per-environment scap.cfg overrides and T145373: Local config deploys should use the target's current version.
@fgiunchedi could you update the scap packages to v.3.3.1-1?
scap (3.3.1-1) unstable; urgency=low * Scap learned how to lock all deployments at the server level. Previously it only knew how to lock deployments at the repo level. * Scap now tells users who holds the lock file (when deploys are locked). Permissions on the lockfile have changed to 600, making it harder to overwrite (Fixes T140914). * "scap sync-file" and "scap pull" got new flags, "--beta-only-change" and "--no-touch", respectively. When used, this prevents the normal action taken by "scap pull" to touch the wmf-config/InitialiseSettings.php file which invalidate local caches. This allows some syncs to avoid a potential problem with HHVM servers exhausting local cache when reading new files from disk. The option is now also always passed to `scap pull` by `scap sync-l10n` (fixes T149872 -- thank you Bryan Davis). * Scap learned to announce scap3 deployments in IRC. This should mean that deployers will no longer have to announce a deployment manually in *-operations -- scap will do it for them. * Scap3 updated the way it limits hosts and can now limit hosts from all groups, not just the default group (Fixes T149128). * HHVM restarts now happen via the /usr/local/bin/restart-hhvm script. This means that an individual server is now depooled via confctl before being restarted (thank you Giuseppe Lavagetto). * Scap3 learned about empty checks in the checks.yml file. This allows you to overwrite global checks in an environment specific checks.yml. These checks will be logged, but nothing will run (fixes T149668). * Scap3 added a "finalize" stage of deployment. This will allow for "promote" checks to execute before the final state is recorded and clean up of old rev directories is performed, and overall result in more consistent rollback behavior (Fixes T150267) * Scap learned how to use sub-sub commands, i.e., scap subcommand subsubcommand. None are yet implemented. * scap l10n-purge works once again, and restart_hhvm was restored (Fixes T146656). * Internally, scap simplified its usage of sudo calls. This means the internals are a bit more sane, unnecessary sudo calls, i.e., sudoing as yourself is less common throughout the code. -- Tyler Cipriani <firstname.lastname@example.org> Thu, 10 Nov 2016 13:41:28 -0800
Can we please get 3.4.1-1 built and uploaded? Thanks! Changelog:
scap (3.4.1-1) unstable; urgency=low * "scap deploy" no longer reports local commits when logging, now relies on last common ancestor with upstream. Prevents leaking security patches and instead reports public info. -- Chad Horohoe <email@example.com> Thu, 1 Dec 2016 21:03:19 -0000
I have a small bugfix release 3.4.2-1 that (aside from the necessary debian/packaging wrangling) only contains the fix for T152390: scap sync-l10n AttributeError: 'Namespace' object has no attribute 'message'
@fgiunchedi can you update the package on carbon?
/me makes puppet patch.
Hiya @fgiunchedi -- I've tagged a debian/3.5.0-1 that is ready for release (puppet patch coming shortly). We've switched to using the release branch in the scap repo. The head of that branch should be where the new release tag is. All the gbp config should work for that branch as it has in the past -- let me know if you find anything configured weirdly.
Here is the full changelog for the new version (it's a biggy):