Page MenuHomePhabricator

OOUI PHP demos on doc.wikimedia.org are broken
Closed, ResolvedPublic

Assigned To
Authored By
Legoktm
Feb 23 2016, 9:53 AM
Tokens
"Mountain of Wealth" token, awarded by Volker_E."Like" token, awarded by Jdforrester-WMF."Orange Medal" token, awarded by Krinkle.

Event Timeline

Change 272689 had a related patch set uploaded (by Legoktm):
demos: Display a nicer error message on old PHP versions

https://gerrit.wikimedia.org/r/272689

Change 272690 had a related patch set uploaded (by Legoktm):
doc: Hide link to OOUI PHP demos because they're broken

https://gerrit.wikimedia.org/r/272690

Change 272690 merged by jenkins-bot:
doc: Hide link to OOUI PHP demos because they're broken

https://gerrit.wikimedia.org/r/272690

Change 272689 merged by jenkins-bot:
demos: Display a nicer error message on old PHP versions

https://gerrit.wikimedia.org/r/272689

Change 272689 merged by jenkins-bot:
demos: Display a nicer error message on old PHP versions

https://gerrit.wikimedia.org/r/272689

As @Jdforrester-WMF realized after merging, this doesn't work because the entire file refuses to parse under PHP5.3.

Change 319673 had a related patch set uploaded (by Legoktm):
Revert "doc: Hide link to OOUI PHP demos because they're broken"

https://gerrit.wikimedia.org/r/319673

Change 319673 merged by jenkins-bot:
Revert "doc: Hide link to OOUI PHP demos because they're broken"

https://gerrit.wikimedia.org/r/319673

Change 319681 had a related patch set uploaded (by Bartosz Dziewoński):
demos: Remove PHP 5.3 compatibility, version check and PHPCS exception

https://gerrit.wikimedia.org/r/319681

Change 319681 merged by jenkins-bot:
demos: Remove PHP 5.3 compatibility, version check and PHPCS exception

https://gerrit.wikimedia.org/r/319681