Page MenuHomePhabricator

[Cross-wiki-upload] indicate article where image was uploaded from
Open, LowestPublic

Description

[...] indicate the original file page on the original wiki

Event Timeline

Josve05a updated the task description. (Show Details)

I'm not a fan of this from the "privacy" viewpoint, maybe I'm a bit paranoid. But I think we should not publicly record the fact that the user attempted to edit article "Foo" until they actually save the edit. I don't feel very strongly about this, though.

Assuming we wanted to implement this (CC @Jdforrester-WMF):

  • My paranoid viewpoint is no longer paranoid if the source wiki is private, exposing a page title could be bad. This affects Wikimedia wikis too, as cross-wiki upload is possible from our private wikis to Commons. We'd have to check for this in the code.
  • I would push to have a brief note in the dialog about this, but I'm not sure how to write this briefly.
  • I would want to check with Legal just in case. (Not anticipating any issues this way, but just in case.)

What I would like the most (and, I imagine, what the Commons community would like the most) would be for the file to not actually be uploaded until the page is saved, and for any file uploads to happen simultaneously with the page save. Right now I'm pretty sure there's no way in MediaWiki to do that, but it should be possible to extend the upload stash functionality to allow it, and to display the images from the stash to the current user (when previewing the article or using VE). This would be a lot of work, though.

matmarex removed matmarex as the assignee of this task.Mar 14 2016, 10:49 PM
Tgr added a subscriber: Tgr.Mar 14 2016, 11:20 PM

What I would like the most (and, I imagine, what the Commons community would like the most) would be for the file to not actually be uploaded until the page is saved, and for any file uploads to happen simultaneously with the page save. Right now I'm pretty sure there's no way in MediaWiki to do that, but it should be possible to extend the upload stash functionality to allow it, and to display the images from the stash to the current user (when previewing the article or using VE). This would be a lot of work, though.

It's possibly but only in a very hacky way. You can use the upload stash, and show thumbnails from it, but:

  • it's uncached and streamed straight from the server and because of that has some pretty restrictive size limitations
  • you cannot stash the image description, you have to keep it around until you unstash the file
  • there is no way to do a page edit and a file unstash (much less an edit and an unstash on two separate wikis) in anything resembling a transaction. (Even simple uploads are not enclosed in a single transaction currently, and can break in messy ways. Not to mention the issue of creating a transaction for a mix of DB and file operations.) That seems very hard.
Poyekhali triaged this task as Lowest priority.Apr 13 2016, 3:47 AM
Poyekhali added a subscriber: Poyekhali.

Change 287103 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] Refactor upload dialog to make it configurable

https://gerrit.wikimedia.org/r/287103

I'm still not convinced this is a good idea, but it's a valid request, so I'm going to make this configurable (off by default) with the patch above and then pass the ball to someone else to hold an RFC or discussion or whatever, and then possibly configure it.

Change 287103 merged by jenkins-bot:
Refactor upload dialog to make it configurable

https://gerrit.wikimedia.org/r/287103

matmarex removed a subscriber: matmarex.

This is now possible to set in configuration, with something like $wgUploadDialog['comment'] = 'Cross-wiki upload from $HOST (page "$PAGENAME")'. I still don't think that should be done, but it's not my decision, and now also not my concern.

Change 289126 had a related patch set uploaded (by Bartosz Dziewoński):
Refactor upload dialog to make it configurable

https://gerrit.wikimedia.org/r/289126

Change 289126 merged by jenkins-bot:
Refactor upload dialog to make it configurable

https://gerrit.wikimedia.org/r/289126

Base added a subscriber: Base.Dec 21 2016, 12:56 PM