Page MenuHomePhabricator
Create Task
Maniphest T128005

Check that Collaboration team projects don't use session state in load.php
Closed, ResolvedPublic
Actions

Description

This is from Scrum of Scrums. Krinkle should send details to wikitech shortly.

Event Timeline

• Mattflaschen-WMF created this task.Feb 24 2016, 7:01 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 24 2016, 7:01 PM
Catrope subscribed.Feb 27 2016, 1:46 AM

Why would any Echo or Flow code be run from load.php? They don't have custom ResourceLoader modules, and they don't hook into ResourceLoaderGetConfigVars.

• Mattflaschen-WMF added a comment.EditedFeb 27 2016, 1:54 AM
In T128005#2068512, @Catrope wrote:

Why would any Echo or Flow code be run from load.php? They don't have custom ResourceLoader modules, and they don't hook into ResourceLoaderGetConfigVars.

Because I filed this before I forgot, so I or someone else could check those things later. :)

• Mattflaschen-WMF closed this task as Resolved.Feb 27 2016, 1:55 AM

Also, Flow does hook into ResourceLoaderGetConfigVars, but it correctly does not vary by user.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL