Page MenuHomePhabricator
Create Task
Maniphest T128034

The BaseHooks extension does not work with modern MediaWiki
Closed, ResolvedPublic
Actions

Description

Extension BaseHooks works only with ancient MediaWiki versions such as 1.19.20.

With current MediaWiki this extension does nothing.

Make it work with current MediaWiki.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix extension.jsonPaladoxmediawiki/extensions/BaseHooksmaster+29 -10
Customize query in gerrit

Related Objects

Event Timeline

VictorPorton created this task.Feb 24 2016, 11:03 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 24 2016, 11:03 PM
Peachey88 added a project: MediaWiki-extensions-General.Feb 25 2016, 6:39 AM
Krenair edited projects, added: MediaWiki-extensions-Other; removed: MediaWiki-extensions-General.Feb 25 2016, 9:09 AM
VictorPorton added a comment.Mar 1 2016, 9:55 PM

I found it does work indeed with modern MediaWiki if we use require_once instead of wfLoadExtension.

gerritbot subscribed.Mar 30 2016, 12:32 PM

Change 280437 had a related patch set uploaded (by Paladox):
Fix extension.json

https://gerrit.wikimedia.org/r/280437

gerritbot added a project: Patch-For-Review.Mar 30 2016, 12:32 PM
Paladox subscribed.Mar 30 2016, 12:33 PM
In T128034#2077568, @VictorPorton wrote:

I found it does work indeed with modern MediaWiki if we use require_once instead of wfLoadExtension.

Hi the reason why extension.json was broken was because you didn't add the correct hooks.

gerritbot added a comment.Mar 30 2016, 4:59 PM

Change 280437 merged by VictorPorton:
Fix extension.json

https://gerrit.wikimedia.org/r/280437

Paladox closed this task as Resolved.Mar 30 2016, 5:59 PM
Paladox claimed this task.

Patches were merged and confirmed to be working for the author of the extension.

Closing as resolved.

Paladox removed a project: Patch-For-Review.Mar 30 2016, 5:59 PM
Paladox removed a subscriber: gerritbot.
VictorPorton mentioned this in rEBHKce926eff3656: Fix extension.json.Mar 30 2016, 6:30 PM
Paladox mentioned this in rEBHKea7897beda2d: Fix extension.json.Apr 28 2016, 12:53 AM
Paladox mentioned this in rEBHKfaddd7a713fb: Fix extension.json.
Paladox mentioned this in rEBHK3984d872047a: Fix extension.json.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits