Page MenuHomePhabricator
Create Task
Maniphest T128091

Migrate OOjs UI npm, npm-run-doc and npm-run-demos CI jobs to Nodepool
Closed, ResolvedPublic
Actions

Description

Details

SubjectRepoBranchLines +/-
Have npm doc to install jsduck with bundlerVisualEditor/VisualEditormaster+15 -1
[oojs/ui] migrate npm doc/demos to Nodepoolintegration/configmaster+4 -11
dib: add jsduck to Nodepool instancesintegration/configmaster+7 -1
Allow hhvm under node-4.3 testsintegration/configmaster+1 -1
Add nodepool parameters to npm-run jobsintegration/configmaster+1 -1
oojs/ui npm jobs needs HHVMintegration/configmaster+4 -0
Experimental npm-run jobs on Nodepool instancesintegration/configmaster+47 -1
[OOJS/ui] Migrate to Node 4.3 / Nodepoolintegration/configmaster+1 -1
Migrate OOJS repos to npm-node-4.3integration/configmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Feb 25 2016, 3:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2016, 3:54 PM
Jdforrester-WMF created subtask T128092: Provide composer on the nodepool servers so OOjs UI can use it in the npm job.Feb 25 2016, 3:55 PM
gerritbot subscribed.Feb 25 2016, 3:59 PM

Change 273135 had a related patch set uploaded (by Jforrester):
Migrate OOJS repos to npm-node-4.3

https://gerrit.wikimedia.org/r/273135

gerritbot added a project: Patch-For-Review.Feb 25 2016, 3:59 PM
Paladox added a subtask: T128135: Jessie should have the ability to run several tests at once like UbuntuTrusty can.Feb 25 2016, 10:12 PM
Paladox removed a subtask: T128135: Jessie should have the ability to run several tests at once like UbuntuTrusty can.
Paladox added a subtask: T128135: Jessie should have the ability to run several tests at once like UbuntuTrusty can.
gerritbot added a comment.Mar 3 2016, 1:39 PM

Change 273135 abandoned by Hashar:
Migrate OOJS repos to npm-node-4.3

Reason:
Can not be switched now because the npm entry point on those repositories use composer which is not available.

https://gerrit.wikimedia.org/r/273135

hashar closed subtask T128135: Jessie should have the ability to run several tests at once like UbuntuTrusty can as Invalid.Mar 8 2016, 1:54 PM
hashar removed a project: Continuous-Integration-Infrastructure.Mar 10 2016, 2:15 PM
hashar subscribed.Apr 1 2016, 6:47 PM

Depends on composer being installed.

hashar mentioned this in T119143: Migrate javascript npm CI jobs to Nodepool.Apr 1 2016, 6:50 PM
hashar mentioned this in T128092: Provide composer on the nodepool servers so OOjs UI can use it in the npm job.Apr 28 2016, 3:23 PM
hashar closed subtask T128092: Provide composer on the nodepool servers so OOjs UI can use it in the npm job as Resolved.

Composer is available. The npm job runs on Jessie which lacks Zend for now but has HHVM. So for oojs/ui we can point it to hhvm.

gerritbot added a comment.Apr 28 2016, 3:25 PM

Change 285974 had a related patch set uploaded (by Hashar):
oojs/ui npm jobs needs HHVM

https://gerrit.wikimedia.org/r/285974

gerritbot added a comment.Apr 28 2016, 3:27 PM

Change 285974 merged by jenkins-bot:
oojs/ui npm jobs needs HHVM

https://gerrit.wikimedia.org/r/285974

hashar added a comment.Apr 28 2016, 3:29 PM

Play test area is https://gerrit.wikimedia.org/r/#/c/285972/

Got an experimental job running at https://integration.wikimedia.org/ci/job/npm-node-4.3/8020/consoleFull

hashar claimed this task.Apr 28 2016, 5:53 PM
hashar removed a project: Patch-For-Review.

The job for OOjs UI passed on the Jessie Nodepool instance. It ran exec:phpGenerateJSPHPForKarma properly under HHVM.

gerritbot added a comment.Apr 28 2016, 5:55 PM

Change 286008 had a related patch set uploaded (by Hashar):
[OOJS/ui] Migrate to Node 4.3 / Nodepool

https://gerrit.wikimedia.org/r/286008

gerritbot added a project: Patch-For-Review.Apr 28 2016, 5:55 PM
hashar renamed this task from Migrate OOjs UI npm CI job to Nodepool to Migrate OOjs UI npm, npm-run-doc and npm-run-demos CI jobs to Nodepool.Apr 28 2016, 5:56 PM
hashar updated the task description. (Show Details)
gerritbot added a comment.Apr 28 2016, 6:25 PM

Change 286008 merged by jenkins-bot:
[OOJS/ui] Migrate to Node 4.3 / Nodepool

https://gerrit.wikimedia.org/r/286008

hashar added a comment.Apr 28 2016, 6:41 PM

OOJSnow runs npm-node-4.3. Still have to migrate npm-run-doc and npm-run-demos

hashar moved this task from Backlog to In-progress on the Continuous-Integration-Scaling board.Apr 29 2016, 10:24 AM
gerritbot added a comment.May 24 2016, 2:15 PM

Change 290467 had a related patch set uploaded (by Hashar):
Experimental npm-run jobs on Nodepool instances

https://gerrit.wikimedia.org/r/290467

gerritbot added a comment.May 24 2016, 2:35 PM

Change 290467 merged by jenkins-bot:
Experimental npm-run jobs on Nodepool instances

https://gerrit.wikimedia.org/r/290467

hashar added a comment.EditedMay 24 2016, 2:42 PM

I have triggered the experimental jobs from gallium in my homedir with:

./trigger-job.py --job oojs-core-npm-run-doc-node-4.3 --project oojs/core --branch master &
./trigger-job.py --job oojs-ui-npm-run-demos-node-4.3 --project oojs/ui --branch master &
./trigger-job.py --job oojs-ui-npm-run-doc-node-4.3 --project oojs/ui --branch master &
./trigger-job.py --job unicodejs-npm-run-doc-node-4.3 --project unicodejs --branch master &
./trigger-job.py --job visualeditor-npm-run-doc-node-4.3 --project VisualEditor/VisualEditor --branch master &
FAILUREhttps://integration.wikimedia.org/ci/job/unicodejs-npm-run-doc-node-4.3/3/Missing jsduck
FAILUREhttps://integration.wikimedia.org/ci/job/visualeditor-npm-run-doc-node-4.3/2/Missing jsduck
FAILUREhttps://integration.wikimedia.org/ci/job/oojs-core-npm-run-doc-node-4.3/3/Missing jsduck
OKhttps://integration.wikimedia.org/ci/job/oojs-ui-npm-run-demos-node-4.3/3/OK
FAILUREhttps://integration.wikimedia.org/ci/job/oojs-ui-npm-run-doc-node-4.3/2/Missing jsduck
hashar added a comment.May 24 2016, 3:09 PM

The missing jsduck is the same issue which is hitting us on parsoid: T126992

hashar mentioned this in T126992: Migrate Parsoid CI jobs to Nodepool and add Node 4.3 support.May 24 2016, 3:09 PM
hashar mentioned this in T136096: Create jsduck job that runs on Nodepool instances.May 24 2016, 3:11 PM
hashar added a subtask: T136096: Create jsduck job that runs on Nodepool instances.

Will create a jsduck job on Nodepool T136096

Paladox subscribed.May 24 2016, 3:20 PM

Ive created https://phabricator.wikimedia.org/T136097 for the Jessie php problem since we want php 5.5 not 5.6. And once we use php 5.5 we could enable it on Jessie.

hashar mentioned this in T136097: Downgrade php on jessie to php 5.5 and enable for use in tests.May 24 2016, 3:25 PM
gerritbot added a comment.May 24 2016, 3:55 PM

Change 290482 had a related patch set uploaded (by Paladox):
Follow-Up: I4eebe5d812d3994a61b133e9d214b52b8b51e71b

https://gerrit.wikimedia.org/r/290482

gerritbot added a comment.May 24 2016, 3:56 PM

Change 290480 had a related patch set uploaded (by Paladox):
Allow hhvm under -jessie and node-4.3 tests

https://gerrit.wikimedia.org/r/290480

gerritbot added a comment.May 24 2016, 4:56 PM

Change 290492 had a related patch set uploaded (by Paladox):
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/290492

gerritbot added a comment.May 24 2016, 7:04 PM

Change 290482 merged by jenkins-bot:
Add nodepool parameters to npm-run jobs

https://gerrit.wikimedia.org/r/290482

gerritbot added a comment.May 24 2016, 7:12 PM

Change 290480 merged by jenkins-bot:
Allow hhvm under node-4.3 tests

https://gerrit.wikimedia.org/r/290480

hashar closed subtask T136096: Create jsduck job that runs on Nodepool instances as Resolved.May 24 2016, 8:30 PM
gerritbot added a comment.May 25 2016, 3:50 PM

Change 290704 had a related patch set uploaded (by Hashar):
dib: add jsduck to Nodepool instances

https://gerrit.wikimedia.org/r/290704

gerritbot added a comment.May 25 2016, 3:52 PM

Change 290704 merged by jenkins-bot:
dib: add jsduck to Nodepool instances

https://gerrit.wikimedia.org/r/290704

gerritbot added a comment.May 25 2016, 8:36 PM

Change 290784 had a related patch set uploaded (by Hashar):
[oojs/ui] migrate npm doc/demos to Nodepool

https://gerrit.wikimedia.org/r/290784

gerritbot added a comment.May 25 2016, 8:49 PM

Change 290784 merged by jenkins-bot:
[oojs/ui] migrate npm doc/demos to Nodepool

https://gerrit.wikimedia.org/r/290784

hashar closed this task as Resolved.May 25 2016, 8:50 PM

We had some experimental jobs added via 5ff89eeb6104cece2e75ed80110ca2a21348fec4 . The doc one failed due to lack of jsduck but it is now installed on the instances.

Did a check experimental on https://gerrit.wikimedia.org/r/#/c/285972/ and both jobs passed.

The jobs will be a bit slow until a change is merged via CR+2. That will populate and store the npm cache for future builds.

Jdforrester-WMF added a comment.May 26 2016, 3:30 PM

\o/

gerritbot added a comment.May 27 2016, 5:29 PM

Change 290492 abandoned by Jforrester:
Have npm doc to install jsduck with bundler

Reason:
Not needed, FWICT.

https://gerrit.wikimedia.org/r/290492

Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.3 on the OOUI board.May 30 2016, 4:02 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.3); removed OOUI.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL