Page MenuHomePhabricator
Create Task
Maniphest T128157

User::loadFromId() triggers redundant memcached lookups
Closed, ResolvedPublic
Actions

Description

User::loadFromId() contains the following check:

if ( $latest || !$this->loadFromCache() ) { /* load from db */ }

If $latest is true, everything is as it should be. If it isn't, then the call to $this->loadFromCache() triggers a memcached lookup, even when user data has already been retrieved from the cache. I have seen over a dozen GETs for the same memcached key in a single request.

Details

SubjectRepoBranchLines +/-
Cache user data in memorymediawiki/coremaster+41 -9
Cache user data in memorymediawiki/corewmf/1.27.0-wmf.14+41 -9
Prevent duplicate memcached lookups for user recordmediawiki/coremaster+11 -5
Prevent duplicate memcached lookups for user recordmediawiki/corewmf/1.27.0-wmf.14+11 -5
Customize query in gerrit

Event Timeline

ori created this task.Feb 26 2016, 1:33 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 26 2016, 1:33 AM
ori added projects: MediaWiki-libs-BagOStuff, MediaWiki-Core-AuthManager, Performance-Team.Feb 26 2016, 1:33 AM
gerritbot subscribed.Feb 26 2016, 6:33 AM

Change 273413 had a related patch set uploaded (by Ori.livneh):
Prevent duplicate memcached lookups for user record

https://gerrit.wikimedia.org/r/273413

gerritbot added a project: Patch-For-Review.Feb 26 2016, 6:33 AM
gerritbot added a comment.Feb 26 2016, 6:28 PM

Change 273496 had a related patch set uploaded (by Ori.livneh):
Prevent duplicate memcached lookups for user record

https://gerrit.wikimedia.org/r/273496

gerritbot added a comment.Feb 26 2016, 6:38 PM

Change 273413 merged by jenkins-bot:
Prevent duplicate memcached lookups for user record

https://gerrit.wikimedia.org/r/273413

gerritbot added a comment.Feb 26 2016, 6:39 PM

Change 273496 merged by jenkins-bot:
Prevent duplicate memcached lookups for user record

https://gerrit.wikimedia.org/r/273496

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-16_(1.27.0-wmf.14)), MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MW-1.27-release-notes.Feb 26 2016, 7:00 PM
ori closed this task as Resolved.Feb 26 2016, 7:18 PM
ori claimed this task.
gerritbot added a comment.Mar 1 2016, 12:01 AM

Change 274023 had a related patch set uploaded (by Gergő Tisza):
Cache user data in memory

https://gerrit.wikimedia.org/r/274023

gerritbot added a comment.Mar 1 2016, 12:34 AM

Change 274023 merged by jenkins-bot:
Cache user data in memory

https://gerrit.wikimedia.org/r/274023

gerritbot added a comment.Mar 1 2016, 12:52 AM

Change 274040 had a related patch set uploaded (by Ori.livneh):
Cache user data in memory

https://gerrit.wikimedia.org/r/274040

gerritbot added a comment.Mar 1 2016, 1:00 AM

Change 274040 merged by jenkins-bot:
Cache user data in memory

https://gerrit.wikimedia.org/r/274040

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits