Page MenuHomePhabricator
Create Task
Maniphest T128197

Login fails with cookies disabled error after CentralAuth update
Closed, ResolvedPublic
Actions

Description

I'm getting the following error repeatedly on the login form when attempting to login after updating to CentralAuth current master.

Login error
Testwiki uses cookies to log in users. You have cookies disabled. Please enable them and try again.

Details

SubjectRepoBranchLines +/-
Take $wgCentralAuthCookies into account when checking CentralAuthSourcemediawiki/extensions/CentralAuthmaster+21 -6
Customize query in gerrit

Related Objects

Event Timeline

Glaisher created this task.Feb 26 2016, 4:41 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 26 2016, 4:41 PM
Glaisher added a comment.Feb 26 2016, 4:50 PM

FWIW, this issue is only present from 7fd01658b5be onwards and I also don't have a loginwiki-like setup locally.

Glaisher added a comment.Feb 26 2016, 4:50 PM

Err, sorry. That is 700d46817974 not the one above.

Anomie added a comment.Feb 26 2016, 7:12 PM

I can't seem to reproduce this on my local system. Does clearing your cookies help?

Tgr added a comment.Feb 26 2016, 8:17 PM

Are you sure it starts happening after that specific patch? Can you check what goes to the 'session' log channel when you do a login attempt? Can you share your centralauth configuration?

Glaisher added a comment.Feb 27 2016, 9:25 AM
In T128197#2067185, @Anomie wrote:

I can't seem to reproduce this on my local system. Does clearing your cookies help?

Nope, errors present still.

In T128197#2067342, @Tgr wrote:

Are you sure it starts happening after that specific patch?

Yep, just checked again. git bisect says it is indeed 700d46817974

Can you check what goes to the 'session' log channel when you do a login attempt?

P2681 (An Untitled Masterwork)
1[session] CentralAuthSessionProvider::provideSessionInfo: Not enabled, falling back to core sessions
2[session] Session "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" requested without UserID cookie
3[session] SessionBackend "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" metadata dirty due to user change
4[session] SessionBackend "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" save: dataDirty=0 metaDirty=1 forcePersist=0
5[session] SessionBackend "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" data dirty due to addData(): MediaWiki\Session\SessionBackend->MediaWiki\Session\{closure}/MediaWiki\Session\SessionBackend->save/CentralAuthSessionProvider->persistSession/MediaWiki\Session\CookieSessionProvider->persistSession/MediaWiki\Session\SessionBackend->addData
6[session] SessionBackend "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" data dirty due to addData(): MediaWiki\Session\SessionBackend->MediaWiki\Session\{closure}/MediaWiki\Session\SessionBackend->save/CentralAuthSessionProvider->persistSession/MediaWiki\Session\CookieSessionProvider->persistSession/MediaWiki\Session\SessionBackend->addData
7[session] Failed to create empty session: [Exception InvalidArgumentException( /var/www/html/wiki/includes/session/SessionManager.php:248) Session ID already exists]
8[session] CentralAuthSessionProvider::provideSessionInfo: Not enabled, falling back to core sessions
9[session] Session "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" requested without UserID cookie
10[session] Session "[30]CentralAuthSessionProvider<anon>mumcfmpbsmfikk0p6juqqpl3f5kffbg5": User ID mismatch, 1 !== 0
11[session] SessionBackend "d3bucfcuo12ciptdcp9ostet4j8lds4s" is unsaved, marking dirty in constructor
12[session] SessionBackend "d3bucfcuo12ciptdcp9ostet4j8lds4s" save: dataDirty=1 metaDirty=1 forcePersist=0
13[session] Saving all sessions on shutdown
14[session] Failed to create empty session: [Exception InvalidArgumentException( /var/www/html/wiki/includes/session/SessionManager.php:248) Session ID already exists]
15[session] MediaWiki\Session\PHPSessionHandler::write: Session "mumcfmpbsmfikk0p6juqqpl3f5kffbg5" cannot be loaded, skipping write.
16[session] CentralAuthSessionProvider::provideSessionInfo: Not enabled, falling back to core sessions
17[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" is unsaved, marking dirty in constructor
18[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" save: dataDirty=1 metaDirty=1 forcePersist=0
19[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" force-persist due to persist()
20[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" save: dataDirty=0 metaDirty=1 forcePersist=1
21[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" Taking over PHP session
22[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" save: dataDirty=0 metaDirty=1 forcePersist=1
23[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" data dirty due to dirty(): LoginForm->mainLoginForm/LoginForm::getLoginToken/MediaWiki\Session\Session->getToken/MediaWiki\Session\Session->set/MediaWiki\Session\SessionBackend->dirty
24[session] Saving all sessions on shutdown
25[session] SessionBackend "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" save: dataDirty=1 metaDirty=0 forcePersist=0
26[session] CentralAuthSessionProvider::provideSessionInfo: Not enabled, falling back to core sessions
27[session] Session "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" requested without UserID cookie
28[session] CentralAuthSessionProvider::provideSessionInfo: Not enabled, falling back to core sessions
29[session] Session "guj8p6m7hrrq5qui4qbqsls1lqri1p8c" requested without UserID cookie
30[session] Saving all sessions on shutdown
31[session] Saving all sessions on shutdown

Can you share your centralauth configuration?

require_once "$IP/extensions/CentralAuth/CentralAuth.php";
$wgCentralAuthAutoNew = true;
$wgCentralAuthAutoMigrate = true;
$wgCentralAuthCreateOnView = true;
$wgCentralAuthSilentLogin = true;
$wgCentralAuthPreventUnattached = true;
$wgCentralAuthCookies = false;
$wgCentralAuthAutoMigrateNonGlobalAccounts = true;
$wgCentralAuthEnableGlobalRenameRequest = true;
$wgCentralAuthEnableUserMerge = true;
Glaisher added a comment.Feb 27 2016, 9:29 AM

I just changed $wgCentralAuthCookies to true now and it now works. Please close this if my previous configuration was incorrect. Thanks.

Anomie added a comment.Feb 27 2016, 4:43 PM
In T128197#2069009, @Glaisher wrote:

I just changed $wgCentralAuthCookies to true now and it now works.

Excellent! I can reproduce it now by setting that to false.

gerritbot subscribed.Feb 27 2016, 4:43 PM

Change 273581 had a related patch set uploaded (by Anomie):
Take $wgCentralAuthCookies into account when checking CentralAuthSource

https://gerrit.wikimedia.org/r/273581

gerritbot added a project: Patch-For-Review.Feb 27 2016, 4:43 PM
gerritbot added a comment.Feb 28 2016, 5:07 AM

Change 273581 merged by jenkins-bot:
Take $wgCentralAuthCookies into account when checking CentralAuthSource

https://gerrit.wikimedia.org/r/273581

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 28 2016, 6:00 AM
Anomie closed this task as Resolved.Feb 29 2016, 3:57 PM
Anomie claimed this task.
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.Dec 15 2016, 4:17 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL