Maniphest T128245

Use $this->getEngine() instead of Scribunto::newDefaultEngine()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JanZerebecki
	Feb 27 2016, 1:15 AM

Tags

Referenced Files

None

Subscribers

Description

Use $this->getEngine() instead of Scribunto::newDefaultEngine() in Scribunto_LuaWikibaseLibraryTest.php and Scribunto_LuaWikibaseEntityLibraryTest.php .

Created because of https://phabricator.wikimedia.org/T128191#2067073 .

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use Scribunto_LuaEngineTestBase::getEngine instead of Scribunto::newDefaultEngine	mediawiki/extensions/Wikibase	master	+11 -34

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		daniel	T204065 WikibaseLexeme CI broken (database errors)
		Invalid		None	T108946 [Epic] Improve the development infrastructure
		Open		None	T249674 Have all Wikimedia production extensions and skins in the CI gate
		Resolved		Addshore	T204153 Add more Wikibase extensions to gatedextensions
		Open		None	T204252 Have dependencies of gated extensions in the gate
		Resolved	PRODUCTION ERROR	Reedy	T198653 Add AntiSpoof to shared extension gate
		Duplicate		None	T200976 Wikibase CI: wmf-quibble-vendor-mysql-hhvm-docker job should include Scribunto
		Resolved		Jdforrester-WMF	T125050 [Task] Add Scribunto to extension-gate in CI
		Resolved		hashar	T202030 CI: Minerva PHPUnit tests should be included in shared extension gate job
		Declined		None	T321864 Add CentralAuth to the gated extensions list
		Stalled		None	T333541 Add CentralAuth to gated extensions
		Resolved		hashar	T126274 MediaWiki gate takes 20 minutes for extensions tests and 1.5 hour for at least a patch
		Resolved		Jdforrester-WMF	T126670 Have CI set `$wgScribuntoDefaultEngine = 'luasandbox` to speed up parser tests
		Resolved		None	T128191 Wikibase Scribunto tests are failing, with the tests depending on configuration
		Resolved		hoo	T128245 Use $this->getEngine() instead of Scribunto::newDefaultEngine()

Event Timeline

JanZerebecki created this task.Feb 27 2016, 1:15 AM

Change 273768 had a related patch set uploaded (by Hoo man):
Use Scribunto_LuaEngineTestBase::getEngine instead of Scribunto::newDefaultEngine

https://gerrit.wikimedia.org/r/273768

gerritbot added a project: Patch-For-Review.Feb 28 2016, 3:05 PM

hoo claimed this task.Feb 28 2016, 3:06 PM

Change 273768 merged by jenkins-bot:
Use Scribunto_LuaEngineTestBase::getEngine instead of Scribunto::newDefaultEngine

https://gerrit.wikimedia.org/r/273768

JanZerebecki closed this task as Resolved.Feb 29 2016, 4:45 PM

JanZerebecki added a project: Wikidata-Sprint-2016-02-16.

Lydia_Pintscher moved this task from Proposed to Done on the Wikidata-Sprint-2016-02-16 board.Feb 29 2016, 9:46 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:42 PM