Flow depends on two php libraries: pimple, and lightncandy.
Pimple is a "simple PHP Dependency Injection Container". Flow uses Pimple 1.0.2, and a modified version of lightncandy 0.15.
The OOui JS Wikimedia Design Style Guide also uses Pimple, but a conflicting version (T88321).
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Flow | master | +7 -330 | Move pimple to composer dependency | |
| mediawiki/vendor | master | +3 K -2 | Add pimple/pimple v2.1.1 for Flow |
Lightncandy is done. It's in core through composer.json (gerrit 181708) and with T86241 Flow uses core's version (gerrit 188534).
That leaves Pimple. Do we need an RFC to rubber-stamp or promote its use beyond the two extensions?
?
If it's needed by an extension, add it to the extensions composer.json in require, and then add it to the Wikimedia vendor repo. Doesn't need adding to MW core itself
https://packagist.org/packages/pimple/pimple
https://github.com/wikimedia/mediawiki-extensions-Flow/commit/4778bb9405e32576b832d03f87af8efbf082154d says it's 2.1.1, so might aswell bring that in by default, and then look at bumping to 3 later
I'll jfdi :)
Change 316073 had a related patch set uploaded (by Reedy):
Add pimple/pimple v2.1.1 for Flow
Change 316074 had a related patch set uploaded (by Reedy):
Move pimple to composer dependancy