[Bug] Add qualifier does not disappear when a new statement is saved
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Feb 28 2016, 11:47 AM

Description

In Firefox, you save a new statement, you can still click on "add qualifier" which is normally clickable only when you edit a whole statement.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix: Add qualifier does not disappear when a new statement is saved	mediawiki/extensions/Wikibase	wmf/1.27.0-wmf.16	+24 -13
	Fix: Add qualifier does not disappear when a new statement is saved	mediawiki/extensions/Wikibase	master	+24 -13

Customize query in gerrit

Related Objects

Duplicates Merged Here: T128963: Save button is not enabled when editing qualifiers

Event Timeline

matej_suchanek created this task.Feb 28 2016, 11:47 AM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 28 2016, 11:47 AM

I can confirm this. You can even add the qualifier, but there's no option to save it. No save button and pressing enter doesn't do anything. When you click edit on the statement you get the possibility to save the qualifier without the need of re-adding the qualifier, the information is still present. But when you can add a qualifier, you expect to be able to save it as well.

I've seen this too.

Lydia_Pintscher renamed this task from Add qualifier does not disappear when a new statement is saved to [Bug] Add qualifier does not disappear when a new statement is saved.Mar 3 2016, 8:04 AM

Lydia_Pintscher triaged this task as Medium priority.

Getting more complaints about this. We need to fix it.

Lydia_Pintscher merged a task: T128963: Save button is not enabled when editing qualifiers.Mar 16 2016, 9:59 AM

Lydia_Pintscher added subscribers: • iecetcwcpggwqpgciazwvzpfjpwomjxn, Fnielsen.

This only happens when number of qualifiers is 0.
The reason is that 'listviewcreate' event is triggered after stop editing.

Change 277782 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fix: Add qualifier does not disappear when a new statement is saved

https://gerrit.wikimedia.org/r/277782

gerritbot added a project: Patch-For-Review.Mar 16 2016, 3:20 PM

Change 277782 merged by jenkins-bot:
Fix: Add qualifier does not disappear when a new statement is saved

https://gerrit.wikimedia.org/r/277782

Lydia_Pintscher closed this task as Resolved.Mar 21 2016, 10:27 AM

Lydia_Pintscher claimed this task.

hoo removed a project: Patch-For-Review.Mar 21 2016, 8:38 PM

Change 278963 had a related patch set uploaded (by Hoo man):
Fix: Add qualifier does not disappear when a new statement is saved

https://gerrit.wikimedia.org/r/278963

gerritbot added a project: Patch-For-Review.Mar 22 2016, 7:24 PM

Change 278963 merged by jenkins-bot:
Fix: Add qualifier does not disappear when a new statement is saved