Race condition with title saving
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Feb 29 2016, 12:38 PM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to reproduce:

Set up an abusefilter rule that warns about titles of length one char
Start translating new page
Name the target title as "op" and let autosave kick in
Now do the following sequence: backspace, ctrl+s, k, ctrl+s, backspace, ctrl+s, k, ctrl+s

Observed: I get title too short warning even though the title is two characters long
Expected: no warning

Additional info:
Looking at the 5 save requests this generates I see these as the saved titles:

op (the initial autosave)
op (expected o)
op (expected ok)
op (expected o)
o (expected ok)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Update mw.cx.targetTitle immediately after title change	Santhosh	mediawiki/extensions/ContentTranslation	master	+9 -9

Customize query in gerrit

Event Timeline

Nikerabbit created this task.Feb 29 2016, 12:38 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 29 2016, 12:38 PM

The storage module saves title by taking value from mw.cx.targetTitle. But when and how that mw.cx.targetTitle is updated?

from ext.cx.translation.js

                this.$title.on( 'blur keyup', $.debounce( 500, function () {
			var title = cxTranslation.$title.text();

			if ( title !== mw.cx.targetTitle ) {
				mw.cx.targetTitle = cxTranslation.$title.text();
				validator.validateTargetTitle();
				mw.hook( 'mw.cx.translation.title.change' ).fire();
			}
		}  )

So, the update is not live. That is the reason for your observation. I think we need to debounce the validation, but not the update to mw.cx.targetTitle i

Change 274056 had a related patch set uploaded (by Santhosh):
Update mw.cx.targetTitle immediately after title change

https://gerrit.wikimedia.org/r/274056

gerritbot added a project: Patch-For-Review.Mar 1 2016, 5:27 AM

santhosh claimed this task.Mar 1 2016, 5:29 AM

santhosh triaged this task as Medium priority.

santhosh added a project: LE-CX8-Sprint 3.

santhosh moved this task from Backlog to In Review on the LE-CX8-Sprint 3 board.

Change 274056 merged by jenkins-bot:
Update mw.cx.targetTitle immediately after title change

https://gerrit.wikimedia.org/r/274056

Nikerabbit moved this task from In Review to QA on the LE-CX8-Sprint 3 board.Mar 1 2016, 6:57 AM

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Mar 1 2016, 7:00 AM

Amire80 added a project: Essential-Work.Mar 3 2016, 7:21 AM

Amire80 moved this task from Needs Triage to CX8 on the ContentTranslation board.Mar 3 2016, 7:28 AM

• Arrbee closed this task as Resolved.Mar 4 2016, 7:44 AM

• Arrbee raised the priority of this task from Medium to High.

• Arrbee moved this task from QA to Done on the LE-CX8-Sprint 3 board.

Race condition with title savingClosed, ResolvedPublicActions

Description

Details

Event Timeline

Race condition with title saving
Closed, ResolvedPublic
Actions