Page MenuHomePhabricator

Set up Code Review office hours
Closed, ResolvedPublic

Description

This was mentioned as one item in the Developer Summit session T114419 and hence is a subtask of T101686.

Action items:
@greg: set up CR office hours (start the practice)

This task seeks to find a format of code review office hours and implement it.


Office Hours scheduled for Thursdays at 20:00 UTC: E179: Code Review Office Hours


{V9}

Related Objects

StatusAssignedTask
ResolvedQgil
ResolvedDicortazar
DuplicateQgil
ResolvedQgil
ResolvedQgil
Resolvedgreg
InvalidNone
InvalidNone
ResolvedQgil
ResolvedAklapper
OpenNone
DeclinedNone
OpenNone
ResolvedAklapper
ResolvedAklapper
ResolvedAklapper
ResolvedDicortazar
ResolvedDicortazar
ResolvedAcs
ResolvedDicortazar
ResolvedDicortazar
ResolvedDicortazar
ResolvedDicortazar
ResolvedDicortazar
ResolvedDicortazar
InvalidDicortazar
ResolvedDicortazar
ResolvedDicortazar
ResolvedAklapper
ResolvedDicortazar
ResolvedDicortazar
DuplicateNone
ResolvedDicortazar
ResolvedBawolff
Resolvedmmodell
ResolvedNone
Resolvedmmodell
ResolvedLegoktm
Resolvedtstarling
OpenNone
Resolvedgreg
ResolvedAklapper
ResolvedAklapper
ResolvedAklapper
ResolvedAklapper
OpenNone
ResolvedNone
ResolvedQuiddity

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

#mediawiki or #wikimedia-dev channels, they are no more human friendly.

There are no bots on #mediawiki anymore. The channel is dead though because we have created channels for each team, department, topic...

This is getting very bikesheddy...

I personally think these bots would be useful during CR office hours because:

  • having a bot say something has been +2 acts as a symbol of success. I think announcing succesful patches would add excitement to the atmosphere
  • during cr office hour, conversation is inevitably going to be split between gerrit and the channel when doing reviews. Having bots makes sure people stay in the loop seems like it would be helpful

Having it in #wikimedia-dev (or #mediawiki) would help involving drive by participants.

Personally, i have pretty severe new channel fatigue

All this is pretty superficial. It doesnt matter where its hosted provided it actually happens

I can add a function to my bot, that the bot unquiets the needed bots for CR hour, and quiets them after that automatically. But for this a) the bot needs +o, and b) we need a channel, which normaly don't uses bots.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 5:59 PM
mmodell updated the task description. (Show Details)May 7 2016, 9:32 PM
mmodell raised the priority of this task from Low to Normal.May 7 2016, 9:35 PM
mmodell closed this task as Resolved.May 9 2016, 4:18 AM
hashar added a comment.May 9 2016, 7:54 AM

From Mukunda email to wikitech-l:

Starting Thursday May 12th, 13:00 PDT ( 20:00 GMT ) we will be having the first weekly Code Review office hours on freenode IRC in the #wikimedia-codereview channel.
Event details: E179

Luke081515 removed a project: Patch-For-Review.
Tgr added a comment.Jun 7 2017, 6:27 PM

Apparently there is a #wikimedia-codereview and a #mediawiki-codereview channel, and the latter is invite-only, which confuses people. Could someone with the right IRC permissions make one a redirect to the other?

I'm lost. Are Code-Review Office Hours still happening? If not, maybe we should cancel the regular Phabricator Calendar event that says they're still happening? Thank you.

The few times I've checked there weren't any participation. It's also very late European time (and not rotating) so I stopped checking.

Thank you for clarifying. I have cancelled as well all recurrent instances of the event.