Page MenuHomePhabricator
Create Task
Maniphest T128473

[Task] Make sure Wikibase extensions don't use Entity class
Closed, ResolvedPublic
Actions

Description

It is really important that all extensions of Wikibase (Quality extensions, PropertySuggestor, ...) and components that use Wikibase code (MobileFrontend, Math, ...) don't use the long deprecated Entity class as we are going to remove it in the next DataModel release.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace all remaining usages of Entity with EntityDocumentmediawiki/extensions/WikibaseQualityConstraintsmaster+86 -105
Favor EntityDocument over Entity when possiblemediawiki/extensions/WikibaseQualityConstraintsmaster+38 -21
Replace all remaining usages of Entity with EntityDocumentmediawiki/extensions/WikibaseQualityExternalValidationmaster+5 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedBeneT126769 [Tracking] Don't typehint against Entity
 ResolvedNoneT128473 [Task] Make sure Wikibase extensions don't use Entity class

Event Timeline

Bene created this task.Mar 1 2016, 3:29 PM
Bene moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-03-01 board.
Physikerwelt subscribed.Mar 1 2016, 6:14 PM

Grep returned one match in the math extension
https://gist.github.com/physikerwelt/ea594a57e62d9af84327#file-mathmlrdfbuildertest-php-L11
@Bene do you know how this can be updated?

daniel added a comment.Mar 1 2016, 6:18 PM

Am 01.03.2016 um 19:14 schrieb Physikerwelt:

Physikerwelt added a comment.

Grep returned one match in the math extension
https://gist.github.com/physikerwelt/ea594a57e62d9af84327#file-mathmlrdfbuildertest-php-L11
@bene do you know how this can be updated?

That's just a reference to the Wikibase\DataModel\Entity namespace, not to the
Entity class. No problem there.

Bene renamed this task from [Task] Make sure Wikibase extensions don't use Entity to [Task] Make sure Wikibase extensions don't use Entity class.Mar 2 2016, 11:04 AM
gerritbot subscribed.Mar 3 2016, 9:20 AM

Change 274658 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Favor EntityDocument over Entity when possible

https://gerrit.wikimedia.org/r/274658

gerritbot added a project: Patch-For-Review.Mar 3 2016, 9:20 AM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-03-01 board.Mar 3 2016, 9:20 AM
thiemowmde added a comment.Mar 3 2016, 9:23 AM

Please also review https://gerrit.wikimedia.org/r/274431, which is pretty much required to be able to do more meaningful changes to the WikibaseQualityConstraints extension.

gerritbot added a comment.Mar 3 2016, 2:56 PM

Change 274717 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace all remaining usages of Entity with EntityDocument

https://gerrit.wikimedia.org/r/274717

gerritbot added a comment.Mar 3 2016, 2:57 PM

Change 274709 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace all remaining usages of Entity with EntityDocument

https://gerrit.wikimedia.org/r/274709

gerritbot added a comment.Mar 3 2016, 3:24 PM

Change 274717 merged by jenkins-bot:
Replace all remaining usages of Entity with EntityDocument

https://gerrit.wikimedia.org/r/274717

gerritbot added a comment.Mar 3 2016, 3:24 PM

Change 274658 merged by jenkins-bot:
Favor EntityDocument over Entity when possible

https://gerrit.wikimedia.org/r/274658

gerritbot added a comment.Mar 3 2016, 4:37 PM

Change 274709 merged by jenkins-bot:
Replace all remaining usages of Entity with EntityDocument

https://gerrit.wikimedia.org/r/274709

daniel added a comment.Mar 3 2016, 4:48 PM

Is this now complete for all extensions?

thiemowmde closed this task as Resolved.Mar 3 2016, 6:14 PM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-03-01 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits