Page MenuHomePhabricator
Create Task
Maniphest T128481

Local block of 114.93.135.192 not expiring on betawikiversity
Closed, ResolvedPublic
Actions

Description

https://beta.wikiversity.org/wiki/Special:Contributions/114.93.135.192 says:

12:02, 19 February 2016 Crochet.david (talk | contribs) blocked 114.93.135.192 (talk) with an expiry time of 3 days (anonymous users only, account creation disabled)
10:23, 1 March 2016: MarcoAurelio (meta.wikimedia.org) globally blocked 114.93.135.192 (expires on 2 March 2016 at 17:23, anonymous only) (Cross-wiki vandalism)

3 days should have expired on Feb 22nd.

mysql:wikiadmin@db1044 [betawikiversity]> select ipb_id, ipb_expiry, ipb_by_text from ipblocks where ipb_address ="114.93.135.192";
+--------+----------------+---------------+
| ipb_id | ipb_expiry     | ipb_by_text   |
+--------+----------------+---------------+
|   3059 | 20160302104208 | Crochet.david |
|   3061 | 20160302104208 | MarcoAurelio  |
+--------+----------------+---------------+
2 rows in set (0.00 sec)

Block 3061 is an autoblock, but somehow 3059 was never purged from the database, and the expiry timestamp was updated to the expirty of 3061??

Related Objects
Search...

Event Timeline

Legoktm created this task.Mar 1 2016, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2016, 5:29 PM
Legoktm added a project: MediaWiki-User-management.Mar 1 2016, 5:29 PM
Restricted Application changed the visibility from "Custom Policy" to "Custom Policy". · View Herald TranscriptMar 1 2016, 5:29 PM
Restricted Application changed the edit policy from "All Users" to "Custom Policy". · View Herald Transcript
Anomie subscribed.Mar 1 2016, 5:44 PM

Seems more likely that Block::updateTimestamp() did it. Which does assume that nothing happened to call Block::purgeExpired() on that wiki since Feb 22; callers are ApiQueryBlocks and 10% of calls to Block::insert().

MarcoAurelio added a comment.Mar 1 2016, 7:11 PM

Thanks for reporting this.

Legoktm created subtask T128695: Block::updateTimestamp() updates expiry of all blocks for the IP.Mar 3 2016, 2:45 AM
• csteipp triaged this task as High priority.Mar 8 2016, 10:18 PM
Legoktm closed subtask T128695: Block::updateTimestamp() updates expiry of all blocks for the IP as Resolved.Mar 14 2016, 10:07 PM
Bawolff subscribed.Apr 22 2016, 3:17 PM

Is there anything more to do on this bug now that T128695 is fixed? I suppose we could remove expired blocks more often, but im not sure I see the point since the system must be designed to work in the face of expired blocks (unless we want to remove them on every request).

Legoktm added a comment.Apr 22 2016, 6:05 PM

Don't think so, we should probably get T128695 backported into the security release?

Bawolff mentioned this in T128695: Block::updateTimestamp() updates expiry of all blocks for the IP.Apr 22 2016, 8:38 PM
MarcoAurelio added a comment.Jul 8 2016, 10:16 PM
In T128481#2231148, @Legoktm wrote:

Don't think so, we should probably get T128695 backported into the security release?

Has that been done?

• dpatrick subscribed.Jul 8 2016, 10:30 PM
In T128481#2443119, @MarcoAurelio wrote:
In T128481#2231148, @Legoktm wrote:

Don't think so, we should probably get T128695 backported into the security release?

Has that been done?

No, it doesn't look like that was backported as part of the last security release. I will add it to the next.

Reedy removed a project: acl*security.Nov 1 2016, 9:30 PM
Reedy changed the visibility from "Custom Policy" to "All Users".
Reedy changed the edit policy from "Custom Policy" to "All Users".
Restricted Application added a project: acl*security. · View Herald TranscriptNov 1 2016, 9:30 PM
Reedy changed Security from Software security bug to None.Nov 1 2016, 9:30 PM
Reedy removed a project: acl*security.
Aklapper changed the visibility from "All Users" to "Public (No Login Required)".Nov 1 2016, 9:31 PM
Reedy closed this task as Resolved.Nov 1 2016, 9:31 PM
Reedy assigned this task to • demon.
Reedy subscribed.

Was released in 1.26.4 and 1.23.15, Chad did the backports!

Aklapper removed subscribers: • dpatrick, Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL