Page MenuHomePhabricator
Create Task
Maniphest T128523

Find/replace dialog in VE overlaps edit notice warning (? in Safari)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Found at https://www.mediawiki.org/wiki/MediaWiki-Vagrant?veaction=edit tested in Firefox 44.0.2 on Mac OS X.

Starting up VisualEditor on a page that can't be visual-edited because of the use of Extension:Translate pops up a warning about that fact; however if you click into the content area and hit cmd+F, the find/replace dialog bar overlaps with the warning message, making it hard to read:

Screen Shot 2016-03-01 at 2.26.52 PM.png (2,560×452 px, 183 KB)

The warning message should ideally bump down below the find/replace bar, or else the find/replace bar should not be activateable in this situation (for one thing you can't replace anything! ;)

Related Objects

Event Timeline

• brooke created this task.Mar 1 2016, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2016, 10:32 PM
santhosh edited projects, added: MediaWiki-extensions-Translate; removed: ContentTranslation.Mar 2 2016, 3:31 AM
santhosh updated the task description. (Show Details)
santhosh subscribed.

@brion, I think you meant the Translate extension, not ContentTranslation which is not installed in mediawiki.org. Edited the description accordingly.

• brooke added a comment.Mar 2 2016, 8:11 PM

@santhosh thanks, I get them mixed up sometimes. :)

Jdforrester-WMF renamed this task from Find/replace dialog in VE overlaps "translateable page" warning to Find/replace dialog in VE overlaps edit notice warning (? in Safari).Apr 19 2016, 7:27 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added: Browser-Support-Apple-Safari, VisualEditor-MediaWiki; removed: MediaWiki-extensions-Translate.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 7:27 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Apr 19 2016, 7:27 PM
DLynch subscribed.Aug 25 2016, 4:37 PM

The overlap seems to have been fixed, at least, ignoring the issue of whether find/replace should be present at all.

pasted_file (962×441 px, 146 KB)

Jdforrester-WMF closed this task as Resolved.Aug 25 2016, 4:55 PM
Jdforrester-WMF assigned this task to Volker_E.
Jdforrester-WMF added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).
Jdforrester-WMF subscribed.

Yeah, this is probably the same bug as T140237: Toolbar dialogs (Special Character, Find & Replace) overlap floating toolbar menus when toolbar is floating

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits