Page MenuHomePhabricator

VisualEditor automatic citation tool breaks url escaping and mangles title
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. https://en.wikipedia.org/w/index.php?title=Emscripten&oldid=707816656&veaction=edit
  2. Select the last reference at the end of the "Software Archiving" section.
  3. Press "Convert".

Actual:

After conversion, the url no longer works correctly. The urlencoded colon in the url has been double url-encoded (from %3A to %253). The colon in the link label also got url-encoded for no apparent reason (it's not a url) - from : to %3A.

Internal wikitext of relevant portion from this revision:

Before:
Wiktext

<ref>[https://archive.org/search.php?query=collection%3Asoftwarelibrary_msdos&page=1 collection:softwarelibrary_msdos]</ref>

Link https://archive.org/search.php?query=collection%3Asoftwarelibrary_msdos&page=1
Label "collection:softwarelibrary_msdos"

After:
Wikitext

<ref>{{Cite web
| url = https://archive.org/search.php?query=collection%253Asoftwarelibrary_msdos&page=1
| title = Internet Archive Search: collection%3Asoftwarelibrary_msdos
| website = archive.org
| access-date = 2016-03-02
}}</ref>

Link https://archive.org/search.php?query=collection%253Asoftwarelibrary_msdos&page=1 (no results)
Label "collection%3Asoftwarelibrary_msdos"

Screen Shot 2016-03-02 at 00.51.57.png (282×407 px, 46 KB)

Screen Shot 2016-03-02 at 00.56.05.png (165×408 px, 29 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle renamed this task from VisualEditor automatic citation tool wrongly escapes url and title (breaks url) to VisualEditor automatic citation tool breaks url escaping and mangles title.Mar 2 2016, 12:59 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a subscriber: Mvolz.
matmarex subscribed.

This seems to be resolved. I followed your steps and got the following output:

image.png (323×841 px, 30 KB)

<ref>{{Cite web|url=https://archive.org/search.php?query=collection:softwarelibrary_msdos&page=1|title=Internet Archive Search: collection:softwarelibrary_msdos|website=archive.org|language=en|access-date=2020-01-04}}</ref>
Restricted Application added a subscriber: Liuxinyu970226. · View Herald Transcript