Page MenuHomePhabricator

Allow marking whole cross-wiki bundles as read
Closed, ResolvedPublic

Description

When cross-wiki bundles contain several notifications it may be convenient to mark all as read in one go. For that purpose we may want to add the usual ways to mark itms as read (the "X" icon and an action under the "..." menu).

Once a cross-wiki bundle is marked as read, all its contents will get marked as read and the bundle will disappear:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2016, 8:06 AM

@jmatazzoni @Pginer-WMF For bundles we have "Expand [#number of msg] ". In this ticket mockup, it says "View [#number of msg]]" - which one should be present?

For testing/comparison after the feature will be implemented.

Presently there is the way to mark all notifications(local and cross-wiki) as read. From comments on T127422: Cross-wiki bundles should appear after local unread notifications in the panel


we do allow to 'Mark all as read' in bundles.
In the screenshot above, I can click on 'Mark as read' - and all notifications(from a local wiki and Chinese wiki) will be marked as read.
In the screenshot below, the option is not present:

@jmatazzoni @Pginer-WMF For bundles we have "Expand [#number of msg] ". In this ticked mockup, it says "View [#number of msg]]" - which one should be present?

View. There is a fix for that in progress according to T121936#2076574

Mooeypoo claimed this task.Mar 2 2016, 8:55 PM

Adding further detail from this morning's meeting (copied over from my now closed bug):

For bundles, including cross-wiki bundles, implement the Mark as Read function, which will work as follows:

  • Available whether the bundle is open or closed.
  • When selected, marks only the x-wiki items currently included in the bundle (i.e., up to a maximum of 25 per wiki).

Note: the Mark All as Read function at the top of the panel affects only local notifications. I.e., it does not affect x-wiki items.

Change 274606 had a related patch set uploaded (by Mooeypoo):
Allow mark as read for a cross-wiki bundle

https://gerrit.wikimedia.org/r/274606

Change 274606 merged by jenkins-bot:
Allow mark as read for a cross-wiki bundle

https://gerrit.wikimedia.org/r/274606

Checked in betalabs according to the following specs:

  • Available whether the bundle is open or closed.
  • When selected, marks only the x-wiki items currently included in the bundle (i.e., up to a maximum of 25 per wiki).

The screenshot shows the case when the foreign wiki notifications are at the top at the Notification panel (unread) and the bundle is not expanded - 'Mark as read' option is present in the dotdotdot menu.

jmatazzoni closed this task as Resolved.Mar 7 2016, 11:55 PM