Page MenuHomePhabricator

Flow failure with Thanks 'check experimental'
Open, Needs TriagePublic

Description

This is about this error from the parent task:

Found in https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/7785/consoleFull

48:16
00:48:16 2) ApiFlowThankTest::testRequestWithoutToken
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 3) ApiFlowThankTest::testInvalidRequest
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 4) ApiFlowThankTest::testValidRequest
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 5) ApiFlowThankTest::testRequestWithInvalidId
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 6) ApiFlowThankTest::testRequestWithOwnId
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 7) ApiFlowThankTest::testApiTestGroup
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 8) ApiFlowThankTest::testMediaWikiTestCaseParentSetupCalled
00:48:16 Flow\Exception\InvalidDataException: User has no id and no ip
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:52
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/UserTuple.php:84
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/AbstractRevision.php:170
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/includes/Model/PostRevision.php:122
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156
00:48:16
00:48:16 --
00:48:16
00:48:16 There was 1 failure:
00:48:16
00:48:16 1) Flow\Tests\Block\TopicListTest::testSortByOption
00:48:16 Default sortby now changed to updated
00:48:16 Failed asserting that two strings are equal.
00:48:16 --- Expected
00:48:16 +++ Actual
00:48:16 @@ @@
00:48:16 -'updated'
00:48:16 +'newest'
00:48:16
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/extensions/Flow/tests/phpunit/Block/TopicListTest.php:58
00:48:16 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm/src/tests/phpunit/MediaWikiTestCase.php:156

Event Timeline

I tried 'check experimental' on a random Flow patch that was passing on regular mode:

https://gerrit.wikimedia.org/r/#/c/274355/

Maybe that will trigger the failure without Thanks particularly involved.

Paladox added a comment.EditedMar 2 2016, 7:41 PM

Yep fails with same error as found on thanks.

https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-composer/1856/consoleFull

But the error happends in the composer version of generic but passes generic which is strange.

Also doing check experimental on https://gerrit.wikimedia.org/r/#/c/274327/ results in passing all the tests which is strange.

Also the failure dosent show flow failing like it does in thanks.

I was expecting it to fail with the Flow error ("Default sortby now changed to updated"). Instead, it failed with the Echo one.

@Mattflaschen yes that is strange I wonder why.

Paladox added a comment.EditedMar 9 2016, 3:06 PM

I think its a bigger problem since I can reproduce on REL1_26 and REL1_25.

I'm now getting some new errors.

23:16:50 2) ApiFlowThankTest::testRequestWithoutToken
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 3) ApiFlowThankTest::testInvalidRequest
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 4) ApiFlowThankTest::testValidRequest
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 5) ApiFlowThankTest::testRequestWithInvalidId
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 6) ApiFlowThankTest::testRequestWithOwnId
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 7) ApiFlowThankTest::testApiTestGroup
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 8) ApiFlowThankTest::testMediaWikiTestCaseParentSetupCalled
23:16:50 Flow\Exception\InvalidDataException: User has no id and no ip
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:52
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/UserTuple.php:84
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/AbstractRevision.php:170
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/includes/Model/PostRevision.php:122
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:223
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiFlowThankIntegrationTest.php:37
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 9) ApiRevThankTest::testValidRequest
23:16:50 UsageException: Revision ID is not valid
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/includes/api/ApiBase.php:1481
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/ApiRevThank.php:41
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/ApiRevThank.php:16
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/includes/api/ApiMain.php:1326
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/includes/api/ApiMain.php:398
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/includes/api/ApiTestCase.php:111
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/includes/api/ApiTestCase.php:158
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Thanks/tests/ApiRevThankIntegrationTest.php:36
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 --
23:16:50
23:16:50 There was 1 failure:
23:16:50
23:16:50 1) Flow\Tests\Block\TopicListTest::testSortByOption
23:16:50 Default sortby now changed to updated
23:16:50 Failed asserting that two strings are equal.
23:16:50 --- Expected
23:16:50 +++ Actual
23:16:50 @@ @@
23:16:50 -'updated'
23:16:50 +'newest'
23:16:50
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/Flow/tests/phpunit/Block/TopicListTest.php:58
23:16:50 /mnt/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:156
23:16:50
23:16:50 --
23:16:50

Paladox updated the task description. (Show Details)Mar 30 2016, 12:51 AM
Paladox added subscribers: JanZerebecki, Legoktm.

@Legoktm and @JanZerebecki can I add you to task please