Also need to add deletion to the "language picker" so that they can also be removed downstream as well.

@JMinor one open question

Is it possible to delete "English" (or whatever the device base language)?

if it is possible then we can still run into the problem of deleting all languages.

or is it based on the position in the stack? language at position 1 cannot be removed? others can be?

If there is no technical cost/risk then I'd say:

• User always must have at minimum one language (aka "primary site language" can not be deleted)
• On first start the current device language should be used as the primary site language
• If the user then "demotes" the device language so it is not the primary site language, they can then delete it
• If the user subsequently changes device language, the app chrome should use the new OS level language, but none of the site or search language settings should change

I leave to you (aka design) how to indicate that the "primary" language is not deletable or prevent the user from trying to delete it.

hey @Fjalapeno, here are the assets for adding/removing languages during the onboarding

@RHo thanks!

https://github.com/wikimedia/wikipedia-ios/pull/655

Testing with iOS 9.3.1 the latest app build Wikipedia 5.0.3 (824). The remove button is listed on both items when there are multiple languages (English-Hebrew and Hebrew-English):

but when there is only one language (English) there is no remove icon:

@Nicholas.tsg just a note, I noticed the cards skipping design signoff. you can drag the cards to design signoff column after the QA.

@Mhurd there are some padding/margin issues. we can work it out offline.

Testing on iPhone with iOS 9.3.1 on the Wikipedia 5.0.3 (836) app.
This original issue is fixed. There is a remove icon for English now.
I filed a bug over another issue with it:
https://phabricator.wikimedia.org/T133361

@JMinor @Nirzar just wanted to triple check this is the expected behaviour – i.e., that user is able to remove the last remaining language?

My understanding was that once user only has 1 language remaining the icon to delete it disappears, per the way this works on iOS general language settings.

Yes, here is what I thought we had, in spec form:

Given that I am on the language edit screen
When I have only one language
Then I should not see the delete control

There are also a few visual design tweaks (padding etc) as well listed below. I can go through in more detail with @Mhurd tomorrow/Mon too if that is faster.

• each language cell should have a top and bottom border
• language tableview should be centre-aligned with width of 243px
• add and delete icons when shown appear to the RHS of the corresponding row (with a 10px gap between icon and row)
• "Choose your preferred language to search Wikipedia" text looks like it is in Regular instead of the expected 'Light' font-weight