Once the i18n code is merged, we will need to register the pageviews tool (http://tools.wmflabs.org/pageviews/) with translatewiki.net so that we can start getting translations. We should also set it up to automatically push the translations to the GitHub repo.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Adding Pageviews Assessment project | translatewiki | master | +46 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lea_WMDE | T143664 Improve page view statistics (#15) | |||
| Resolved | None | T120497 Pageview Stats tool | |||
| Resolved | None | T127856 Add links to https://tools.wmflabs.org/pageviews from top 10 wikis | |||
| Resolved | MusikAnimal | T128770 Add language selector to Settings interface in pageviews tool | |||
| Resolved | kaldari | T128768 Register pageviews tool with translatewiki.net | |||
| Resolved | kaldari | T128103 Add i18n support to pageviews tool with Intuition |
Event Timeline
Comment Actions
According to @Nikerabbit, we need to supply a logo, label, and short description.
Logo: https://translatewiki.net/wiki/File:Pageviews_Analysis.svg
Label: Pageviews Analysis
Description: Pageviews Analysis provides visualization of pageview statistics for Wikimedia project pages.
Here are some examples of new projects being added to the TranslateWiki repo:
https://gerrit.wikimedia.org/r/#/c/272492/
https://gerrit.wikimedia.org/r/#/c/270813/
Comment Actions
The i18n files will eventually live at:
https://github.com/MusikAnimal/pageviews/tree/master/messages
(Hopefully by the end of tomorrow)
Right now they are at https://github.com/MusikAnimal/pageviews/tree/php/messages
Comment Actions
All set! The PHP branch has been merged and deployed :) If you want to handle setting up translatewiki.net that'd be awesome. I'm going to try to clean up the views one last time... possibly moving back to HAML. Shouldn't interfere with your work. Many thanks for the help!
Comment Actions
Change 275131 had a related patch set uploaded (by Kaldari):
Adding Pageviews Assessment project to translatewiki.net
Comment Actions
Per https://github.com/Krinkle/intuition/wiki/Migrate, https://gerrit.wikimedia.org/r/237193 might be a good example. I don't know the exact translatewiki.net configuration myself, either.
Comment Actions
The repo the strings live in, and translations have to be added to. I assume that's https://github.com/MusikAnimal/pageviews?
Comment Actions
@siebrand Yes I believe they will in https://github.com/MusikAnimal/pageviews/tree/master/messages. However would a pull request not suffice? I'd prefer to restrict push access to active maintainers.
Comment Actions
Pardon my lack of understanding. Just did some reading and see that you are both staff members that handle integrating with git repos, on behalf of other volunteer translators? No problem, then :) That makes a lot more sense, just didn't want to have to grant access to each individual translator, understandably. I've added you both.
Whenever you push, you might see Travis CI complain about the build failing, just ignore it. I haven't got it working yet with our new PHP setup, but either way it doesn't apply to the translations. Thanks!
Comment Actions
After https://gerrit.wikimedia.org/r/#/c/275131/ is merged, https://gerrit.wikimedia.org/r/#/c/275372/ is step 2.
Comment Actions
@kaldari Thanks, I was wondering where we were with this. Do you need a code review on that commit? Are we waiting for the translatewiki team to merge it?
Comment Actions
@MusikAnimal: Yeah, basically waiting for Niklas (from the translatewiki team) to get back from vacation, which should be next week.
Comment Actions
We also need a project page like https://translatewiki.net/wiki/Translating:Crosswatch (among the things I don't know: whether there is a suitable component on phabricator).
Comment Actions
@Krinkle @siebrand @Nikerabbit I see that some translators are putting in {{PLURAL}} as in the MediaWiki magic word. This syntax is not recognizable by Intuition/PHP and errors out such that you get a blank page. Is there a way we can ensure it is not added moving forward? Or maybe there is some pluralization functionality that Intuition offers?
Comment Actions
Does this provide any answers? https://github.com/Krinkle/intuition/wiki/Documentation#user-content-message-functions
Comment Actions
It does, thank you. I guess we'll need to decide which messages might involve pluralization, as I assume there's some performance factor here or else it would always parse for magic words.
Comment Actions
Please don't worry about performance unless you are processing thousands of messages. It looks like that API got some inspirations from the old messaging system from MediaWiki before we enabled magic word parsing the default.
If you are passing variables that already is a strong hint that parsemag is likely needed.