Page MenuHomePhabricator

Echo should not hook into itself with EchoAbortEmailNotification
Open, Needs TriagePublic

Description

Echo should not hook into itself, it should just call the relevant code there.

Event Timeline

Legoktm created this task.Mar 3 2016, 6:30 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 3 2016, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 275358 had a related patch set uploaded (by Tahteche):
Echo should not hook into itself with EchoAbortEmailNotification

https://gerrit.wikimedia.org/r/275358

Provided a patch to this but I was clarified that it is meant to be this way because "the old Hooks::run call resulted in Flow's function being run, this does not."

Should this be listed as a bug then? Help me out if there is anything am missing so I can rework my solution.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 20 2016, 11:25 PM
Framawiki moved this task from Backlog to Doing on the good first bug board.Dec 2 2017, 1:34 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 24 2018, 9:54 AM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Sep 28 2018, 2:28 AM
tahteche removed tahteche as the assignee of this task.Oct 4 2018, 6:24 AM
tahteche removed a subscriber: tahteche.