Page MenuHomePhabricator
Create Task
Maniphest T128777

Move Navigation Timing reporter to separate repo (scap-deployed)
Closed, DeclinedPublic
Actions

Description

Move code to a dedicated repository, turn it into a proper Python module, add tests, configure CI.

Then remove puppet file resources and instead deploy through scap from Git.

Original task description:

navtiming.py started life as a quick hack, and gradually grew to its current proportions. It's not a disaster yet, but it is definitely on the path to becoming spaghetti.

Some ideas:

  • Use eventlogging.EventConsumer instead of lower-level APIs (ZeroMQ).
  • Upstream @handles decorator.
  • Provide some abstraction to assist with metric segmentation (i.e., reporting a metric with multiple key names / prefixes.)
  • Move code to a dedicated repository, turn it into a proper Python module, add tests, configure CI.

Related Objects
Search...

Event Timeline

ori created this task.Mar 3 2016, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2016, 7:26 PM
ori added a parent task: T128709: Segment Navigation Timing data by continent.Mar 3 2016, 7:33 PM
ori claimed this task.Mar 7 2016, 6:55 PM
ori triaged this task as High priority.
ori moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Peter subscribed.Mar 8 2016, 10:05 AM
Krinkle subscribed.Dec 7 2016, 7:29 PM

Use of ZeroMQ and EventLogging is tracked here:

Basic tests were recently added for NavTiming as well.

Re-purposing this task for the move to a separate repo and presumably deploying through scap instead of puppet.

Krinkle renamed this task from Navigation Timing metric reporter (navtiming.py) should be refactored to Move Navigation Timing reporter to separate repo (scap-deployed).Dec 7 2016, 7:31 PM
Krinkle lowered the priority of this task from High to Low.
Krinkle updated the task description. (Show Details)
Krinkle added a comment.Mar 9 2017, 10:17 PM
In T128777#2855064, @Krinkle wrote:

Use of ZeroMQ and EventLogging is tracked here:

Basic tests were recently added for NavTiming as well.

Closing this task. It's fine in puppet for now. The above three improvements are on the way to implementation.

Krinkle closed this task as Declined.Mar 9 2017, 10:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL